Skip to content

Commit

Permalink
add defer function for mandatorily delete the nodelatencymonitor CR
Browse files Browse the repository at this point in the history
Signed-off-by: Rupam-It <mannarupam3@gmail.com>
  • Loading branch information
Rupam-It committed Sep 3, 2024
1 parent 09f8471 commit 3b0d16f
Showing 1 changed file with 7 additions and 15 deletions.
22 changes: 7 additions & 15 deletions test/e2e/nodelatencymonitor_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,11 @@ func TestNodeLatencyMonitor(t *testing.T) {
require.NoError(t, err, "Failed to create NodeLatencyMonitor CR")
t.Logf("NodeLatencyMonitor CR created successfully.")

defer func() {
err = data.crdClient.CrdV1alpha1().NodeLatencyMonitors().Delete(context.TODO(), "default", metav1.DeleteOptions{})
require.NoError(t, err, "Failed to delete NodeLatencyMonitor CR")
t.Logf("NodeLatencyMonitor CR deleted successfully.")
}()
previousTimes := make(map[string]map[string]metav1.Time)

validateNodeLatencyStats := func(statsList *v1alpha1.NodeLatencyStatsList, initialPoll bool) (bool, error) {
Expand Down Expand Up @@ -93,12 +98,7 @@ func TestNodeLatencyMonitor(t *testing.T) {
if err != nil {
return false, err
}

valid, validateErr := validateNodeLatencyStats(statsList, true)
if !valid {
return false, validateErr
}
return true, nil
return validateNodeLatencyStats(statsList, true)
})
require.NoError(t, err, "Failed to validate initial NodeLatencyStats")

Expand All @@ -107,18 +107,10 @@ func TestNodeLatencyMonitor(t *testing.T) {
if err != nil {
return false, err
}

valid, validateErr := validateNodeLatencyStats(statsList, false)
if !valid {
return false, validateErr
}
return true, nil
return validateNodeLatencyStats(statsList, false)
})
require.NoError(t, err, "Failed to validate updated NodeLatencyStats")

t.Logf("Successfully received and validated NodeLatencyStats")

err = data.crdClient.CrdV1alpha1().NodeLatencyMonitors().Delete(context.TODO(), "default", metav1.DeleteOptions{})
require.NoError(t, err, "Failed to delete NodeLatencyMonitor CR")
t.Logf("NodeLatencyMonitor CR deleted successfully.")
}

0 comments on commit 3b0d16f

Please sign in to comment.