Stop using projects.registry.vmware.com for user-facing images #6073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
added
area/build-release
We stop referencing the VMware Harbor registry (projects.registry.vmware.com) in the Helm charts and K8s manifests that we release to users, with the expectation that images for future releases will not be available from that registry, as it is scheduled to be EOL'd and we won't be mirroring them there. Because the antrea DockerHub organization is part of the "Sponsored OSS" program, there should be no concern about users running into issues because of DockerHub rate-limits. We could also consider mirroring these images to ghcr.io in the future, to offer users an alternative. At the moment, we do not update references to other images in the projects.registry.vmware.com/antrea project (images used for testing), with the expectation that they will remain available for the foreseeable future. In other words, while we will no longer be publishing new images to projects.registry.vmware.com, we expect that existing images will remain available through the same URLs. For antrea-io#6003 Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
antoninbas
force-pushed
the
stop-using-projects.registry.vmware.com-for-user-facing-images
branch
from
f9740b3 to
e8aabf3
Compare
luolanzone
reviewed
Mar 7, 2024
| @@ -152,10 +152,10 @@ function version_lt() { test "$(printf '%s\n' "$@" | sort -rV | head -n 1)" != " | |||
|
|
|||
| DOCKER_IMAGES=() | |||
| if version_lt "$FROM_TAG" v1.15; then | |||
| DOCKER_IMAGES+=("projects.registry.vmware.com/antrea/antrea-ubuntu:$FROM_TAG") | |||
| DOCKER_IMAGES+=("antrea/antrea-ubuntu:$FROM_TAG") | |||
There was a problem hiding this comment.
Should we keep this as before considering it's only for testing? I am thinking the test may fail more frequently due to Docker rate limit.
There was a problem hiding this comment.
Another question is should we release a new patch release after the backport? cc @tnqn
There was a problem hiding this comment.
We don't have rate-limit as explained in the PR description.
Yes, we should release new patch releases, there has been some bugfixes accumulated.
There was a problem hiding this comment.
I am not getting that why we change the images from Dockerhub to Harbor registry at the first place? I recalled it was because of rate limits? Or Antrea wasn't a part of the "Sponsored OSS" programs when the registry is changed?
tnqn
approved these changes
Mar 7, 2024
| @@ -152,10 +152,10 @@ function version_lt() { test "$(printf '%s\n' "$@" | sort -rV | head -n 1)" != " | |||
|
|
|||
| DOCKER_IMAGES=() | |||
| if version_lt "$FROM_TAG" v1.15; then | |||
| DOCKER_IMAGES+=("projects.registry.vmware.com/antrea/antrea-ubuntu:$FROM_TAG") | |||
| DOCKER_IMAGES+=("antrea/antrea-ubuntu:$FROM_TAG") | |||
There was a problem hiding this comment.
We don't have rate-limit as explained in the PR description.
Yes, we should release new patch releases, there has been some bugfixes accumulated.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
/test-all |
antoninbas
deleted the
stop-using-projects.registry.vmware.com-for-user-facing-images
branch
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Mar 7, 2024
…a-io#6073) We stop referencing the VMware Harbor registry (projects.registry.vmware.com) in the Helm charts and K8s manifests that we release to users, with the expectation that images for future releases will not be available from that registry, as it is scheduled to be EOL'd and we won't be mirroring them there. Because the antrea DockerHub organization is part of the "Sponsored OSS" program, there should be no concern about users running into issues because of DockerHub rate-limits. We could also consider mirroring these images to ghcr.io in the future, to offer users an alternative. At the moment, we do not update references to other images in the projects.registry.vmware.com/antrea project (images used for testing), with the expectation that they will remain available for the foreseeable future. In other words, while we will no longer be publishing new images to projects.registry.vmware.com, we expect that existing images will remain available through the same URLs. For antrea-io#6003 Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Mar 7, 2024
…a-io#6073) We stop referencing the VMware Harbor registry (projects.registry.vmware.com) in the Helm charts and K8s manifests that we release to users, with the expectation that images for future releases will not be available from that registry, as it is scheduled to be EOL'd and we won't be mirroring them there. Because the antrea DockerHub organization is part of the "Sponsored OSS" program, there should be no concern about users running into issues because of DockerHub rate-limits. We could also consider mirroring these images to ghcr.io in the future, to offer users an alternative. At the moment, we do not update references to other images in the projects.registry.vmware.com/antrea project (images used for testing), with the expectation that they will remain available for the foreseeable future. In other words, while we will no longer be publishing new images to projects.registry.vmware.com, we expect that existing images will remain available through the same URLs. For antrea-io#6003 Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Mar 7, 2024
…a-io#6073) We stop referencing the VMware Harbor registry (projects.registry.vmware.com) in the Helm charts and K8s manifests that we release to users, with the expectation that images for future releases will not be available from that registry, as it is scheduled to be EOL'd and we won't be mirroring them there. Because the antrea DockerHub organization is part of the "Sponsored OSS" program, there should be no concern about users running into issues because of DockerHub rate-limits. We could also consider mirroring these images to ghcr.io in the future, to offer users an alternative. At the moment, we do not update references to other images in the projects.registry.vmware.com/antrea project (images used for testing), with the expectation that they will remain available for the foreseeable future. In other words, while we will no longer be publishing new images to projects.registry.vmware.com, we expect that existing images will remain available through the same URLs. For antrea-io#6003 Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
antoninbas
added a commit
that referenced
this pull request
Mar 8, 2024
#6082) We stop referencing the VMware Harbor registry (projects.registry.vmware.com) in the Helm charts and K8s manifests that we release to users, with the expectation that images for future releases will not be available from that registry, as it is scheduled to be EOL'd and we won't be mirroring them there. Because the antrea DockerHub organization is part of the "Sponsored OSS" program, there should be no concern about users running into issues because of DockerHub rate-limits. We could also consider mirroring these images to ghcr.io in the future, to offer users an alternative. At the moment, we do not update references to other images in the projects.registry.vmware.com/antrea project (images used for testing), with the expectation that they will remain available for the foreseeable future. In other words, while we will no longer be publishing new images to projects.registry.vmware.com, we expect that existing images will remain available through the same URLs. For #6003 Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
tnqn
pushed a commit
that referenced
this pull request
Mar 11, 2024
#6083) We stop referencing the VMware Harbor registry (projects.registry.vmware.com) in the Helm charts and K8s manifests that we release to users, with the expectation that images for future releases will not be available from that registry, as it is scheduled to be EOL'd and we won't be mirroring them there. Because the antrea DockerHub organization is part of the "Sponsored OSS" program, there should be no concern about users running into issues because of DockerHub rate-limits. We could also consider mirroring these images to ghcr.io in the future, to offer users an alternative. At the moment, we do not update references to other images in the projects.registry.vmware.com/antrea project (images used for testing), with the expectation that they will remain available for the foreseeable future. In other words, while we will no longer be publishing new images to projects.registry.vmware.com, we expect that existing images will remain available through the same URLs. For #6003 Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
tnqn
pushed a commit
that referenced
this pull request
Mar 11, 2024
#6084) We stop referencing the VMware Harbor registry (projects.registry.vmware.com) in the Helm charts and K8s manifests that we release to users, with the expectation that images for future releases will not be available from that registry, as it is scheduled to be EOL'd and we won't be mirroring them there. Because the antrea DockerHub organization is part of the "Sponsored OSS" program, there should be no concern about users running into issues because of DockerHub rate-limits. We could also consider mirroring these images to ghcr.io in the future, to offer users an alternative. At the moment, we do not update references to other images in the projects.registry.vmware.com/antrea project (images used for testing), with the expectation that they will remain available for the foreseeable future. In other words, while we will no longer be publishing new images to projects.registry.vmware.com, we expect that existing images will remain available through the same URLs. For #6003 Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We stop referencing the VMware Harbor registry
(projects.registry.vmware.com) in the Helm charts and K8s manifests that we release to users, with the expectation that images for future releases will not be available from that registry, as it is scheduled to be EOL'd and we won't be mirroring them there.
Because the antrea DockerHub organization is part of the "Sponsored OSS" program, there should be no concern about users running into issues because of DockerHub rate-limits. We could also consider mirroring these images to ghcr.io in the future, to offer users an alternative.
At the moment, we do not update references to other images in the projects.registry.vmware.com/antrea project (images used for testing), with the expectation that they will remain available for the foreseeable future. In other words, while we will no longer be publishing new images to projects.registry.vmware.com, we expect that existing images will remain available through the same URLs.
For #6003