Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from projects.registry.vmware.com to Dockerhub #6003

Open
3 of 4 tasks
tnqn opened this issue Feb 20, 2024 · 11 comments
Open
3 of 4 tasks

Switch from projects.registry.vmware.com to Dockerhub #6003

tnqn opened this issue Feb 20, 2024 · 11 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@tnqn
Copy link
Member

tnqn commented Feb 20, 2024 •
edited by antoninbas
Loading

Describe the bug

projects.registry.vmware.com/antrea may be unavailable after May 2024.

  • We should stop publishing any new manifests using that image repo.
  • For existing release manifest and charts, we need to decide if they should be updated to point to Dockerhub, or just release patch releases with new image links.
  • Figure out how to avoid/fix impact to existing clusters.
  • Switch images to Dockerhub for Jenkins CI scripts Replace Harbor images with DockerHub images #6076

Is there anything else may be affected?
@tnqn tnqn added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 20, 2024
@antoninbas
Copy link
Contributor

For the second point, I think new patch releases for releases currently maintained is the way to go.

Even if we mutate artifacts for existing releases (which may not even be possible for Helm chart releases), this would still not solve a key issue: existing clusters can be impacted by the deletion of the existing images (e.g., when scaling up the cluster with new Nodes). Unless there is an "automatic redirect" solution, there is no way to avoid impact to users.

@tnqn
Copy link
Member Author

tnqn commented Feb 21, 2024 •
edited
Loading

Even if we mutate artifacts for existing releases (which may not even be possible for Helm chart releases), this would still not solve a key issue: existing clusters can be impacted by the deletion of the existing images (e.g., when scaling up the cluster with new Nodes). Unless there is an "automatic redirect" solution, there is no way to avoid impact to users.

Right. That would be really bad for existing clusters. Hope there will be a smoother transition in the end, otherwise we may have to highlight this change somewhere.

@tnqn
Copy link
Member Author

tnqn commented Feb 21, 2024

Added 3rd task for existing clusters.

@antoninbas
Copy link
Contributor

antoninbas commented Feb 29, 2024 •
edited
Loading

For the 1st task, we should roll out this change before the v2 release. I'll add this to the release milestone.

@antoninbas antoninbas added this to the Antrea v2.0 release milestone Feb 29, 2024
@antoninbas
Copy link
Contributor

For the 1st task, we should roll out this change before the v2 release. I'll add this to the release milestone.

I am currently working on this

antoninbas added a commit to vmware/go-ipfix that referenced this issue Mar 6, 2024
@antoninbas
Stop referencing the VMware Harbor registry for ipfix-collector
29d4699 
The ipfix-collector YAML manifest should no longer reference the VMware
Harbor registry. The image should be pulled from DockerHub.

See antrea-io/antrea#6003

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
@antoninbas antoninbas mentioned this issue Mar 6, 2024
Merged
antoninbas added a commit to antoninbas/antrea that referenced this issue Mar 6, 2024
@antoninbas
Stop using projects.registry.vmware.com for user-facing images
f9740b3 
We stop referencing the VMware Harbor registry
(projects.registry.vmware.com) in the Helm charts and K8s manifests that
we release to users, with the expectation that images for future
releases will not be available from that registry, as it is scheduled to
be EOL'd and we won't be mirroring them there.

Because the antrea DockerHub organization is part of the "Sponsored OSS"
program, there should be no concern about users running into issues
because of DockerHub rate-limits. We could also consider mirroring these
images to ghcr.io in the future, to offer users an alternative.

At the moment, we do not update references to other images in the
projects.registry.vmware.com/antrea project (images used for testing),
with the expectation that they will remain available for the foreseeable
future. In other words, while we will no longer be publishing new images
to projects.registry.vmware.com, we expect that existing images will
remain available through the same URLs.

For antrea-io#6003

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
@antoninbas antoninbas mentioned this issue Mar 6, 2024
Merged
heanlan pushed a commit to vmware/go-ipfix that referenced this issue Mar 7, 2024
@antoninbas
Stop referencing the VMware Harbor registry for ipfix-collector (#347)
03d04a6 
The ipfix-collector YAML manifest should no longer reference the VMware
Harbor registry. The image should be pulled from DockerHub.

See antrea-io/antrea#6003

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
antoninbas added a commit to antoninbas/antrea that referenced this issue Mar 7, 2024
@antoninbas
Stop using projects.registry.vmware.com for user-facing images
e8aabf3 
We stop referencing the VMware Harbor registry
(projects.registry.vmware.com) in the Helm charts and K8s manifests that
we release to users, with the expectation that images for future
releases will not be available from that registry, as it is scheduled to
be EOL'd and we won't be mirroring them there.

Because the antrea DockerHub organization is part of the "Sponsored OSS"
program, there should be no concern about users running into issues
because of DockerHub rate-limits. We could also consider mirroring these
images to ghcr.io in the future, to offer users an alternative.

At the moment, we do not update references to other images in the
projects.registry.vmware.com/antrea project (images used for testing),
with the expectation that they will remain available for the foreseeable
future. In other words, while we will no longer be publishing new images
to projects.registry.vmware.com, we expect that existing images will
remain available through the same URLs.

For antrea-io#6003

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
antoninbas added a commit that referenced this issue Mar 7, 2024
@antoninbas
Stop using projects.registry.vmware.com for user-facing images (#6073)
e16e6b6 
We stop referencing the VMware Harbor registry
(projects.registry.vmware.com) in the Helm charts and K8s manifests that
we release to users, with the expectation that images for future
releases will not be available from that registry, as it is scheduled to
be EOL'd and we won't be mirroring them there.

Because the antrea DockerHub organization is part of the "Sponsored OSS"
program, there should be no concern about users running into issues
because of DockerHub rate-limits. We could also consider mirroring these
images to ghcr.io in the future, to offer users an alternative.

At the moment, we do not update references to other images in the
projects.registry.vmware.com/antrea project (images used for testing),
with the expectation that they will remain available for the foreseeable
future. In other words, while we will no longer be publishing new images
to projects.registry.vmware.com, we expect that existing images will
remain available through the same URLs.

For #6003

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
antoninbas added a commit to antoninbas/antrea that referenced this issue Mar 7, 2024
@antoninbas
Stop using projects.registry.vmware.com for user-facing images (antre…
136b511 
…a-io#6073)

We stop referencing the VMware Harbor registry
(projects.registry.vmware.com) in the Helm charts and K8s manifests that
we release to users, with the expectation that images for future
releases will not be available from that registry, as it is scheduled to
be EOL'd and we won't be mirroring them there.

Because the antrea DockerHub organization is part of the "Sponsored OSS"
program, there should be no concern about users running into issues
because of DockerHub rate-limits. We could also consider mirroring these
images to ghcr.io in the future, to offer users an alternative.

At the moment, we do not update references to other images in the
projects.registry.vmware.com/antrea project (images used for testing),
with the expectation that they will remain available for the foreseeable
future. In other words, while we will no longer be publishing new images
to projects.registry.vmware.com, we expect that existing images will
remain available through the same URLs.

For antrea-io#6003

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
antoninbas added a commit to antoninbas/antrea that referenced this issue Mar 7, 2024
@antoninbas
Stop using projects.registry.vmware.com for user-facing images (antre…
b53b1f7 
…a-io#6073)

We stop referencing the VMware Harbor registry
(projects.registry.vmware.com) in the Helm charts and K8s manifests that
we release to users, with the expectation that images for future
releases will not be available from that registry, as it is scheduled to
be EOL'd and we won't be mirroring them there.

Because the antrea DockerHub organization is part of the "Sponsored OSS"
program, there should be no concern about users running into issues
because of DockerHub rate-limits. We could also consider mirroring these
images to ghcr.io in the future, to offer users an alternative.

At the moment, we do not update references to other images in the
projects.registry.vmware.com/antrea project (images used for testing),
with the expectation that they will remain available for the foreseeable
future. In other words, while we will no longer be publishing new images
to projects.registry.vmware.com, we expect that existing images will
remain available through the same URLs.

For antrea-io#6003

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
antoninbas added a commit to antoninbas/antrea that referenced this issue Mar 7, 2024
@antoninbas
Stop using projects.registry.vmware.com for user-facing images (antre…
d89982e 
…a-io#6073)

We stop referencing the VMware Harbor registry
(projects.registry.vmware.com) in the Helm charts and K8s manifests that
we release to users, with the expectation that images for future
releases will not be available from that registry, as it is scheduled to
be EOL'd and we won't be mirroring them there.

Because the antrea DockerHub organization is part of the "Sponsored OSS"
program, there should be no concern about users running into issues
because of DockerHub rate-limits. We could also consider mirroring these
images to ghcr.io in the future, to offer users an alternative.

At the moment, we do not update references to other images in the
projects.registry.vmware.com/antrea project (images used for testing),
with the expectation that they will remain available for the foreseeable
future. In other words, while we will no longer be publishing new images
to projects.registry.vmware.com, we expect that existing images will
remain available through the same URLs.

For antrea-io#6003

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
antoninbas added a commit that referenced this issue Mar 8, 2024
@antoninbas
Stop using projects.registry.vmware.com for user-facing images (#6073) (
bcc887b 
#6082)

We stop referencing the VMware Harbor registry
(projects.registry.vmware.com) in the Helm charts and K8s manifests that
we release to users, with the expectation that images for future
releases will not be available from that registry, as it is scheduled to
be EOL'd and we won't be mirroring them there.

Because the antrea DockerHub organization is part of the "Sponsored OSS"
program, there should be no concern about users running into issues
because of DockerHub rate-limits. We could also consider mirroring these
images to ghcr.io in the future, to offer users an alternative.

At the moment, we do not update references to other images in the
projects.registry.vmware.com/antrea project (images used for testing),
with the expectation that they will remain available for the foreseeable
future. In other words, while we will no longer be publishing new images
to projects.registry.vmware.com, we expect that existing images will
remain available through the same URLs.

For #6003

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
tnqn pushed a commit that referenced this issue Mar 11, 2024
@antoninbas
Stop using projects.registry.vmware.com for user-facing images (#6073) (
164a14f 
#6083)

We stop referencing the VMware Harbor registry
(projects.registry.vmware.com) in the Helm charts and K8s manifests that
we release to users, with the expectation that images for future
releases will not be available from that registry, as it is scheduled to
be EOL'd and we won't be mirroring them there.

Because the antrea DockerHub organization is part of the "Sponsored OSS"
program, there should be no concern about users running into issues
because of DockerHub rate-limits. We could also consider mirroring these
images to ghcr.io in the future, to offer users an alternative.

At the moment, we do not update references to other images in the
projects.registry.vmware.com/antrea project (images used for testing),
with the expectation that they will remain available for the foreseeable
future. In other words, while we will no longer be publishing new images
to projects.registry.vmware.com, we expect that existing images will
remain available through the same URLs.

For #6003

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
tnqn pushed a commit that referenced this issue Mar 11, 2024
@antoninbas
Stop using projects.registry.vmware.com for user-facing images (#6073) (
a0123e3 
#6084)

We stop referencing the VMware Harbor registry
(projects.registry.vmware.com) in the Helm charts and K8s manifests that
we release to users, with the expectation that images for future
releases will not be available from that registry, as it is scheduled to
be EOL'd and we won't be mirroring them there.

Because the antrea DockerHub organization is part of the "Sponsored OSS"
program, there should be no concern about users running into issues
because of DockerHub rate-limits. We could also consider mirroring these
images to ghcr.io in the future, to offer users an alternative.

At the moment, we do not update references to other images in the
projects.registry.vmware.com/antrea project (images used for testing),
with the expectation that they will remain available for the foreseeable
future. In other words, while we will no longer be publishing new images
to projects.registry.vmware.com, we expect that existing images will
remain available through the same URLs.

For #6003

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
@luolanzone
Copy link
Contributor

I added item 4 'Switch images to Dockerhub for Jenkins CI scripts' in this issue. @XinShuYang could you help to work on this? Thanks.

@XinShuYang
Copy link
Contributor

I added item 4 'Switch images to Dockerhub for Jenkins CI scripts' in this issue. @XinShuYang could you help to work on this? Thanks.

We had discussion for this update #6076 (comment). If @antoninbas agree I can proceed with this PR to switch testing images.

@antoninbas
Copy link
Contributor

@XinShuYang Yes, we should proceed with that change now. Image mirroring to Harbor has now been disabled. All our scripts and CI jobs should stop pulling images from Harbor.

@antoninbas
Copy link
Contributor

Everything that needed to be addressed for the v2 release has been taken care of. Moving the issue out of the milestone.

The one open question is how we can avoid impacting existing users / clusters. At this time, it looks like the old image URLs will remain valid, with an automatic redirection from the old registry to the new one. We will update this issue when we have more information.

@antoninbas antoninbas removed this from the Antrea v2.0 release milestone Apr 24, 2024
@rguske rguske mentioned this issue Jun 28, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 24, 2024
@antoninbas antoninbas removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@antoninbas @tnqn @XinShuYang @luolanzone