Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows image building error in jenkins pipeline #4697

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

XinShuYang
Copy link
Contributor

@XinShuYang XinShuYang commented Mar 9, 2023

DOCKER_REGISTRY is no longer needed in agent image tag.
Remove it to align with containerd image tag in CI pipeline.

Update more image tags which is unavailable in public repo.

Fixes #4696

@XinShuYang
Copy link
Contributor Author

/test-windows-all

1 similar comment
@XinShuYang
Copy link
Contributor Author

/test-windows-all

@XinShuYang
Copy link
Contributor Author

/test-windows-e2e

1 similar comment
@XinShuYang
Copy link
Contributor Author

/test-windows-e2e

@XinShuYang
Copy link
Contributor Author

/test-windows-proxyall-e2e

1 similar comment
@XinShuYang
Copy link
Contributor Author

/test-windows-proxyall-e2e

@XinShuYang
Copy link
Contributor Author

/test-windows-conformance

@XinShuYang
Copy link
Contributor Author

/test-windows-networkpolicy

@XinShuYang
Copy link
Contributor Author

/test-windows-proxyall-e2e

@XinShuYang
Copy link
Contributor Author

/test-windows-conformance

1 similar comment
@XinShuYang
Copy link
Contributor Author

/test-windows-conformance

@XinShuYang
Copy link
Contributor Author

/test-windows-proxyall-e2e

@XinShuYang
Copy link
Contributor Author

/test-windows-conformance

1 similar comment
@XinShuYang
Copy link
Contributor Author

/test-windows-conformance

@XinShuYang
Copy link
Contributor Author

/test-windows-conformance

@XinShuYang
Copy link
Contributor Author

/test-windows-conformance

@XinShuYang
Copy link
Contributor Author

/test-windows-networkpolicy

@XinShuYang
Copy link
Contributor Author

/test-windows-networkpolicy

@XinShuYang
Copy link
Contributor Author

/test-windows-networkpolicy

@XinShuYang
Copy link
Contributor Author

/test-windows-networkpolicy

@XinShuYang
Copy link
Contributor Author

/test-windows-all

@XinShuYang
Copy link
Contributor Author

/test-all

@XinShuYang
Copy link
Contributor Author

/test-windows-e2e

@XinShuYang
Copy link
Contributor Author

/test-windows-e2e
/test-windows-networkpolicy

1 similar comment
@XinShuYang
Copy link
Contributor Author

/test-windows-e2e
/test-windows-networkpolicy

@XinShuYang
Copy link
Contributor Author

/test-windows-networkpolicy

1 similar comment
@XinShuYang
Copy link
Contributor Author

/test-windows-networkpolicy

harbor_images=("sigwindowstools-kube-proxy:v1.18.0" "agnhost:2.13" "agnhost:2.13" "agnhost:2.29" "e2eteam-jessie-dnsutils:1.0" "e2eteam-pause:3.2")
antrea_images=("sigwindowstools/kube-proxy:v1.18.0" "e2eteam/agnhost:2.13" "us.gcr.io/k8s-artifacts-prod/e2e-test-images/agnhost:2.13" "k8s.gcr.io/e2e-test-images/agnhost:2.29" "e2eteam/jessie-dnsutils:1.0" "e2eteam/pause:3.2")
harbor_images=("sigwindowstools-kube-proxy:v1.18.0" "agnhost:2.13" "agnhost:2.13" "agnhost:2.29" "e2eteam-jessie-dnsutils:1.0" "e2eteam-jessie-dnsutils:1.0" "e2eteam-pause:3.2" "e2eteam-pause:3.2" "e2eteam-busybox:1.29-windows-amd64-1809")
antrea_images=("sigwindowstools/kube-proxy:v1.18.0" "e2eteam/agnhost:2.13" "us.gcr.io/k8s-artifacts-prod/e2e-test-images/agnhost:2.13" "k8s.gcr.io/e2e-test-images/agnhost:2.29" "e2eteam/jessie-dnsutils:1.0" "gcr.io/kubernetes-e2e-test-images/jessie-dnsutils:1.0" "e2eteam/pause:3.2" "k8s.gcr.io/pause:3.2" "docker.io/library/busybox:1.29")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are these changes needed? how did it work if they are not available?

Copy link
Contributor Author

@XinShuYang XinShuYang Mar 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubernetes just declared k8s.gcr.io will not be available https://kubernetes.io/blog/2023/03/10/image-registry-redirect/ , and recently I also found some image tags like docker.io/library/busybox:1.29 are not available on windows node

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old registry will still be available, but anyway it's not bad to avoid pulling the image again when we already download it from harbor registry.

DOCKER_REGISTRY is no longer needed in agent image tag.
Remove it to align with containerd image tag in CI pipeline.

Update more image tags which is unavailable in public repo.

Fixes antrea-io#4696

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
@XinShuYang
Copy link
Contributor Author

/test-windows-all

Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn
Copy link
Member

tnqn commented Mar 14, 2023

@XinShuYang windows-e2e and windows-networkpolicy still failed, please let me know if they are related.

@XinShuYang
Copy link
Contributor Author

@tnqn yes they are not related to this patch. Manual test passed so we can just merge this pr to recover the windows testbed first.

@tnqn
Copy link
Member

tnqn commented Mar 14, 2023

/skip-all

@tnqn tnqn merged commit 1f92bb9 into antrea-io:main Mar 14, 2023
luolanzone pushed a commit to luolanzone/antrea that referenced this pull request Mar 29, 2023
DOCKER_REGISTRY is no longer needed in agent image tag.
Remove it to align with containerd image tag in CI pipeline.

Update more image tags which is unavailable in public repo.

Fixes antrea-io#4696

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
luolanzone pushed a commit to luolanzone/antrea that referenced this pull request Mar 29, 2023
DOCKER_REGISTRY is no longer needed in agent image tag.
Remove it to align with containerd image tag in CI pipeline.

Update more image tags which is unavailable in public repo.

Fixes antrea-io#4696

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
luolanzone pushed a commit to luolanzone/antrea that referenced this pull request Mar 29, 2023
DOCKER_REGISTRY is no longer needed in agent image tag.
Remove it to align with containerd image tag in CI pipeline.

Update more image tags which is unavailable in public repo.

Fixes antrea-io#4696

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
tnqn pushed a commit that referenced this pull request Mar 31, 2023
DOCKER_REGISTRY is no longer needed in agent image tag.
Remove it to align with containerd image tag in CI pipeline.

Update more image tags which is unavailable in public repo.

Fixes #4696

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
tnqn pushed a commit that referenced this pull request Mar 31, 2023
DOCKER_REGISTRY is no longer needed in agent image tag.
Remove it to align with containerd image tag in CI pipeline.

Update more image tags which is unavailable in public repo.

Fixes #4696

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
tnqn pushed a commit that referenced this pull request Mar 31, 2023
DOCKER_REGISTRY is no longer needed in agent image tag.
Remove it to align with containerd image tag in CI pipeline.

Update more image tags which is unavailable in public repo.

Fixes #4696

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
jainpulkit22 pushed a commit to urharshitha/antrea that referenced this pull request Apr 28, 2023
DOCKER_REGISTRY is no longer needed in agent image tag.
Remove it to align with containerd image tag in CI pipeline.

Update more image tags which is unavailable in public repo.

Fixes antrea-io#4696

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

windows e2e test used stale image on one Node
2 participants