Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #4160: Avoid redundant Openflow messages when syncing an updated #4162

Conversation

hongliangl
Copy link
Contributor

Cherry pick of #4160 on release-1.7.

#4160: Avoid redundant Openflow messages when syncing an updated

For details on the cherry pick process, see the cherry pick requests page.

Fix antrea-io#4159

This PR fix the issue by appending buckets directly in `Done()` in
pkg/ovs/openflow/ofctrl_group.go instead of calling `AddBuckets` method
of `Group` defined in the ofnet which sends an Openflow message to install
the group.

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
@hongliangl hongliangl added the kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release label Aug 29, 2022
@hongliangl hongliangl requested a review from tnqn August 29, 2022 15:11
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #4162 (26816f6) into release-1.7 (3d74de2) will increase coverage by 1.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.7    #4162      +/-   ##
===============================================
+ Coverage        62.61%   63.89%   +1.27%     
===============================================
  Files              293      293              
  Lines            43405    43405              
===============================================
+ Hits             27177    27732     +555     
+ Misses           14022    13437     -585     
- Partials          2206     2236      +30     
Flag Coverage Δ
kind-e2e-tests 50.03% <100.00%> (+2.24%) ⬆️
unit-tests 44.48% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/ovs/openflow/ofctrl_group.go 50.76% <100.00%> (ø)
.../agent/flowexporter/priorityqueue/priorityqueue.go 65.55% <0.00%> (-27.78%) ⬇️
pkg/agent/flowexporter/connections/conntrack.go 71.42% <0.00%> (-14.29%) ⬇️
pkg/agent/controller/networkpolicy/packetin.go 57.74% <0.00%> (-11.98%) ⬇️
pkg/agent/flowexporter/utils.go 72.34% <0.00%> (-4.26%) ⬇️
pkg/apiserver/storage/ram/watch.go 90.66% <0.00%> (-2.67%) ⬇️
pkg/ipam/poolallocator/allocator.go 53.49% <0.00%> (-0.97%) ⬇️
...ntroller/networkpolicy/networkpolicy_controller.go 72.80% <0.00%> (+1.00%) ⬆️
pkg/controller/ipam/antrea_ipam_controller.go 76.41% <0.00%> (+1.31%) ⬆️
pkg/agent/proxy/proxier.go 62.92% <0.00%> (+2.43%) ⬆️
... and 13 more

@tnqn
Copy link
Member

tnqn commented Aug 30, 2022

/skip-all

@tnqn tnqn merged commit 3b03389 into antrea-io:release-1.7 Aug 30, 2022
@hongliangl hongliangl deleted the automated-cherry-pick-of-#4160-upstream-release-1.7 branch October 25, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants