Avoid redundant Openflow messages when syncing an updated group to OVS #4160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix antrea-io#4159 This PR fix the issue by appending buckets directly in `Done()` in pkg/ovs/openflow/ofctrl_group.go instead of calling `AddBuckets` method of `Group` defined in the ofnet which sends an Openflow message to install the group. Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
hongliangl
added
the
area/proxy
Codecov Report
@@ Coverage Diff @@
## main #4160 +/- ##
==========================================
+ Coverage 56.38% 65.75% +9.37%
==========================================
Files 417 303 -114
Lines 60811 46531 -14280
==========================================
- Hits 34286 30596 -3690
+ Misses 23743 13584 -10159
+ Partials 2782 2351 -431
*This pull request uses carry forward flags. Click here to find out more.
|
|
/test-all |
tnqn
added
the
action/release-note
|
Since the original code causes great unnecessary overhead when used in large scale, I would suggest to backport the fix. |
Yes, do we need to backport this to earlier versions? Like the versions before v1.0? @tnqn |
This was referenced Aug 29, 2022
Merged
Merged
Merged
Merged
Closed
|
@hongliangl please backport to release 1.5 and later. |
Done. |
heanlan
pushed a commit
to heanlan/antrea
that referenced
this pull request
Mar 29, 2023
antrea-io#4160) Fix antrea-io#4159 This PR fix the issue by appending buckets directly in `Done()` in pkg/ovs/openflow/ofctrl_group.go instead of calling `AddBuckets` method of `Group` defined in the ofnet which sends an Openflow message to install the group. Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4159
This PR fixes the issue by appending buckets directly in
Done()inpkg/ovs/openflow/ofctrl_group.go instead of calling
AddBucketsmethodof
Groupdefined in the ofnet which sends an Openflow message to installthe group.
Signed-off-by: Hongliang Liu lhongliang@vmware.com