-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all legacy (*.antrea.tanzu.vmware.com) APIs #3299
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3299 +/- ##
==========================================
- Coverage 58.97% 54.79% -4.19%
==========================================
Files 331 371 +40
Lines 28420 50756 +22336
==========================================
+ Hits 16762 27810 +11048
- Misses 9843 20543 +10700
- Partials 1815 2403 +588
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to see we remove these! But assume we will need the mirror code back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one minor comment.
Feel much cleaner now. There were 18% (135) files were related to legacy API.
/test-all |
Hopefully not. This was required because of the API naming change. CRD version changes don't require our own mirroring logic as K8s provides the machinery for version conversion. |
These APIs were scheduled for deletion in December 2021. So it seems reasonable to remove them in Antrea v1.6, without causing significant disruption to users. As part of this, the CRD mirroring controller code can be removed entirely and the legacyCRDMirroring config option for the controller is deprecated (it's a no-op and users trying to set this option to anything will see a warning in the logs). The API dcoumentation is updated. We add a note to inform users who may still be using Antrea pre-v1.0 that they will need to make an intermediate upgrade first and migrate their CRDs, if they want to upgrade to Antrea >= v1.6. Fixes antrea-io#3298 Signed-off-by: Antonin Bas <abas@vmware.com>
Signed-off-by: Antonin Bas <abas@vmware.com>
fc585fe
to
3aea040
Compare
/test-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test-e2e |
These APIs were scheduled for deletion in December 2021. So it seems reasonable to remove them in Antrea v1.6, without causing significant disruption to users. As part of this, the CRD mirroring controller code can be removed entirely and the legacyCRDMirroring config option for the controller is deprecated (it's a no-op and users trying to set this option to anything will see a warning in the logs). The API documentation is updated. We add a note to inform users who may still be using Antrea pre-v1.0 that they will need to make an intermediate upgrade first and migrate their CRDs, if they want to upgrade to Antrea >= v1.6. Fixes antrea-io#3298 Signed-off-by: Antonin Bas <abas@vmware.com>
These APIs were scheduled for deletion in December 2021. So it seems
reasonable to remove them in Antrea v1.6, without causing significant
disruption to users.
As part of this, the CRD mirroring controller code can be removed
entirely and the legacyCRDMirroring config option for the controller is
deprecated (it's a no-op and users trying to set this option to anything
will see a warning in the logs).
The API dcoumentation is updated. We add a note to inform users who may
still be using Antrea pre-v1.0 that they will need to make an
intermediate upgrade first and migrate their CRDs, if they want to
upgrade to Antrea >= v1.6.
Fixes #3298
Signed-off-by: Antonin Bas abas@vmware.com