Migrate ClusterClaim to ClusterProperty #4686
Assignees
Labels
area/multi-cluster
Issues or PRs related to multi cluster.
kind/design
Categorizes issue or PR as related to design.
Comments
luolanzone
added
kind/design
|
Hi,
Here is the cope of move ClusterClaim to ClusterProperty issue:
1. Docs: docs/multicluster docs
2. Designed the new ClusterProperty which conforms to the requirements, and the generated codes
3. New ClusterProperty webhook and its unit-tests. If we want support both ClusterClaim and ClusterProperty,
we also need a convert here.
4. Multicluster/build yamls and config yamls
5. Multicluster/controllers of ClustersetController in both Leaders and Members, MemberClusterAnnounceController, ClusterProperty itself Controller.
6. Pkg/client versioned informers and listers, which can be generated automatically
7. Integration’s test codes and yamls
8. Antctl ’s destroy command, init command, join command, cleanup command, deploy leader cluster command and deploy member cluster command, and the common file. And change the test files. If we want support both ClusterClaim and ClusterProperty, we need to find a way to deal with two CRD here.
The biggest variable now is whether we should support both versions, if the answer is yes, what approach we should take. We should convert the old ClusterClaim forcefully or not, if we support both version, do we want two CRDs running in the same cluster? Do we want the users to run the migrate code to ClusterClaim to ClusterProperty at last? I think a discussion should be done if we want to do this.
Thanks,
Bangqi
From: Lan ***@***.***>
Date: Tuesday, March 7, 2023 at 9:32 PM
To: antrea-io/antrea ***@***.***>
Cc: Bangqi Zhu ***@***.***>, Assign ***@***.***>
Subject: [antrea-io/antrea] Migrate ClusterClaim to ClusterProperty (Issue #4686)
!! External Email
Describe what you are trying to solve
Antrea Multi-cluster is using ClusterClaim CRD to allow user to claim a cluster in a ClusterSet. We was following the definition in KEP2149<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkubernetes%2Fenhancements%2Ftree%2Fmaster%2Fkeps%2Fsig-multicluster%2F2149-clusterid&data=05%7C01%7Czbangqi%40vmware.com%7C53578e19c68a43ff397f08db1f968dee%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C638138503730198560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=V9L3xWhPKurefj8yXHDH51U9630xYBoqSOlSMC8%2BwSM%3D&reserved=0>, but the CRD is changed from ClusterClaim to ClusterProperty, ClusterClaim is no longer used in upstream. It's better to follow upstream definition in Antrea Multi-cluster.
Describe the solution you have in mind
1. Remove ClusterClaim and add ClusterProperty CRD.
2. Support both ClusterClaim and ClusterProperty CRDs (preferred).
Describe how your solution impacts user flows
This will impact the way how to initialize a ClusterSet from user perspective. We should cover following cases when we do MC controllers refinement.
1. Migrate existing ClusterClaim to ClusterProperty and watch ClusterProperty change and update only after migration
2. ClusterProperty controller should cover all current ClusterClaim's use case.
—
Reply to this email directly, view it on GitHub<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fantrea-io%2Fantrea%2Fissues%2F4686&data=05%7C01%7Czbangqi%40vmware.com%7C53578e19c68a43ff397f08db1f968dee%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C638138503730198560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4tZXYLP%2BuBedlvkRcNXP1xuvWIKstyMFR1WA6u3p52U%3D&reserved=0>, or unsubscribe<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQNNN6WGU3O3VXRBHHXER33W3AKYBANCNFSM6AAAAAAVTK62DI&data=05%7C01%7Czbangqi%40vmware.com%7C53578e19c68a43ff397f08db1f968dee%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C638138503730198560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=LbFU0L087WBhH4BScZtWMvYQBw3ozt68I8MsYztybC8%3D&reserved=0>.
You are receiving this because you were assigned.Message ID: ***@***.***>
!! External Email: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender.
|
|
@jianjun ***@***.***>/ @lan ***@***.***> Could you please direct @bangqi ***@***.***> for the right approach?
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Bangqi Zhu ***@***.***>
Sent: Monday, March 13, 2023 10:55:36 PM
To: antrea-io/antrea ***@***.***>; Akshay Katrekar ***@***.***>; Krishna Miriyala ***@***.***>
Cc: Lan Luo ***@***.***>; Jianjun Shen ***@***.***>
Subject: Re: [antrea-io/antrea] Migrate ClusterClaim to ClusterProperty (Issue #4686)
Hi,
Here is the cope of move ClusterClaim to ClusterProperty issue:
1. Docs: docs/multicluster docs
2. Designed the new ClusterProperty which conforms to the requirements, and the generated codes
3. New ClusterProperty webhook and its unit-tests. If we want support both ClusterClaim and ClusterProperty,
we also need a convert here.
4. Multicluster/build yamls and config yamls
5. Multicluster/controllers of ClustersetController in both Leaders and Members, MemberClusterAnnounceController, ClusterProperty itself Controller.
6. Pkg/client versioned informers and listers, which can be generated automatically
7. Integration’s test codes and yamls
8. Antctl ’s destroy command, init command, join command, cleanup command, deploy leader cluster command and deploy member cluster command, and the common file. And change the test files. If we want support both ClusterClaim and ClusterProperty, we need to find a way to deal with two CRD here.
The biggest variable now is whether we should support both versions, if the answer is yes, what approach we should take. We should convert the old ClusterClaim forcefully or not, if we support both version, do we want two CRDs running in the same cluster? Do we want the users to run the migrate code to ClusterClaim to ClusterProperty at last? I think a discussion should be done if we want to do this.
Thanks,
Bangqi
From: Lan ***@***.***>
Date: Tuesday, March 7, 2023 at 9:32 PM
To: antrea-io/antrea ***@***.***>
Cc: Bangqi Zhu ***@***.***>, Assign ***@***.***>
Subject: [antrea-io/antrea] Migrate ClusterClaim to ClusterProperty (Issue #4686)
!! External Email
Describe what you are trying to solve
Antrea Multi-cluster is using ClusterClaim CRD to allow user to claim a cluster in a ClusterSet. We was following the definition in KEP2149<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkubernetes%2Fenhancements%2Ftree%2Fmaster%2Fkeps%2Fsig-multicluster%2F2149-clusterid&data=05%7C01%7Czbangqi%40vmware.com%7C53578e19c68a43ff397f08db1f968dee%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C638138503730198560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=V9L3xWhPKurefj8yXHDH51U9630xYBoqSOlSMC8%2BwSM%3D&reserved=0>, but the CRD is changed from ClusterClaim to ClusterProperty, ClusterClaim is no longer used in upstream. It's better to follow upstream definition in Antrea Multi-cluster.
Describe the solution you have in mind
1. Remove ClusterClaim and add ClusterProperty CRD.
2. Support both ClusterClaim and ClusterProperty CRDs (preferred).
Describe how your solution impacts user flows
This will impact the way how to initialize a ClusterSet from user perspective. We should cover following cases when we do MC controllers refinement.
1. Migrate existing ClusterClaim to ClusterProperty and watch ClusterProperty change and update only after migration
2. ClusterProperty controller should cover all current ClusterClaim's use case.
—
Reply to this email directly, view it on GitHub<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fantrea-io%2Fantrea%2Fissues%2F4686&data=05%7C01%7Czbangqi%40vmware.com%7C53578e19c68a43ff397f08db1f968dee%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C638138503730198560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4tZXYLP%2BuBedlvkRcNXP1xuvWIKstyMFR1WA6u3p52U%3D&reserved=0>, or unsubscribe<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQNNN6WGU3O3VXRBHHXER33W3AKYBANCNFSM6AAAAAAVTK62DI&data=05%7C01%7Czbangqi%40vmware.com%7C53578e19c68a43ff397f08db1f968dee%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C638138503730198560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=LbFU0L087WBhH4BScZtWMvYQBw3ozt68I8MsYztybC8%3D&reserved=0>.
You are receiving this because you were assigned.Message ID: ***@***.***>
!! External Email: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender.
|
|
Ideally, we should do mirroring of CRDs - using a mirroring controller to convert old CRDs to new ones, and other code just handles new CRDs. You can check the following PRs to learn more:
Remove all legacy (*.antrea.tanzu.vmware.com) APIs by antoninbas · Pull Request #3299 · antrea-io/antrea (github.com)<#3299>
Rename API groups from *.antrea.tanzu.vmware.com to *.antrea.io by hongliangl · Pull Request #1799 · antrea-io/antrea (github.com)<#1799>
However, I did not look into ClusterProperty to know if it is easy to be mirrored to ClusterClaim. Could you evaluate the approach?
In any case, I feel we could just support the new CRDs with antctl, and document only the new CRDs in documentation. Users can switch to old version antctl/documents for old CRDs.
Jianjun
…________________________________
From: Krishna Miriyala ***@***.***>
Sent: Tuesday, March 14, 2023 8:14
To: Bangqi Zhu ***@***.***>; antrea-io/antrea ***@***.***>; Akshay Katrekar ***@***.***>; Jianjun Shen ***@***.***>; Lan Luo ***@***.***>
Cc: Lan Luo ***@***.***>; Jianjun Shen ***@***.***>
Subject: Re: [antrea-io/antrea] Migrate ClusterClaim to ClusterProperty (Issue #4686)
@jianjun ***@***.***>/ @lan ***@***.***> Could you please direct @bangqi ***@***.***> for the right approach?
Get Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: Bangqi Zhu ***@***.***>
Sent: Monday, March 13, 2023 10:55:36 PM
To: antrea-io/antrea ***@***.***>; Akshay Katrekar ***@***.***>; Krishna Miriyala ***@***.***>
Cc: Lan Luo ***@***.***>; Jianjun Shen ***@***.***>
Subject: Re: [antrea-io/antrea] Migrate ClusterClaim to ClusterProperty (Issue #4686)
Hi,
Here is the cope of move ClusterClaim to ClusterProperty issue:
1. Docs: docs/multicluster docs
2. Designed the new ClusterProperty which conforms to the requirements, and the generated codes
3. New ClusterProperty webhook and its unit-tests. If we want support both ClusterClaim and ClusterProperty,
we also need a convert here.
4. Multicluster/build yamls and config yamls
5. Multicluster/controllers of ClustersetController in both Leaders and Members, MemberClusterAnnounceController, ClusterProperty itself Controller.
6. Pkg/client versioned informers and listers, which can be generated automatically
7. Integration’s test codes and yamls
8. Antctl ’s destroy command, init command, join command, cleanup command, deploy leader cluster command and deploy member cluster command, and the common file. And change the test files. If we want support both ClusterClaim and ClusterProperty, we need to find a way to deal with two CRD here.
The biggest variable now is whether we should support both versions, if the answer is yes, what approach we should take. We should convert the old ClusterClaim forcefully or not, if we support both version, do we want two CRDs running in the same cluster? Do we want the users to run the migrate code to ClusterClaim to ClusterProperty at last? I think a discussion should be done if we want to do this.
Thanks,
Bangqi
From: Lan ***@***.***>
Date: Tuesday, March 7, 2023 at 9:32 PM
To: antrea-io/antrea ***@***.***>
Cc: Bangqi Zhu ***@***.***>, Assign ***@***.***>
Subject: [antrea-io/antrea] Migrate ClusterClaim to ClusterProperty (Issue #4686)
!! External Email
Describe what you are trying to solve
Antrea Multi-cluster is using ClusterClaim CRD to allow user to claim a cluster in a ClusterSet. We was following the definition in KEP2149<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkubernetes%2Fenhancements%2Ftree%2Fmaster%2Fkeps%2Fsig-multicluster%2F2149-clusterid&data=05%7C01%7Czbangqi%40vmware.com%7C53578e19c68a43ff397f08db1f968dee%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C638138503730198560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=V9L3xWhPKurefj8yXHDH51U9630xYBoqSOlSMC8%2BwSM%3D&reserved=0>, but the CRD is changed from ClusterClaim to ClusterProperty, ClusterClaim is no longer used in upstream. It's better to follow upstream definition in Antrea Multi-cluster.
Describe the solution you have in mind
1. Remove ClusterClaim and add ClusterProperty CRD.
2. Support both ClusterClaim and ClusterProperty CRDs (preferred).
Describe how your solution impacts user flows
This will impact the way how to initialize a ClusterSet from user perspective. We should cover following cases when we do MC controllers refinement.
1. Migrate existing ClusterClaim to ClusterProperty and watch ClusterProperty change and update only after migration
2. ClusterProperty controller should cover all current ClusterClaim's use case.
—
Reply to this email directly, view it on GitHub<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fantrea-io%2Fantrea%2Fissues%2F4686&data=05%7C01%7Czbangqi%40vmware.com%7C53578e19c68a43ff397f08db1f968dee%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C638138503730198560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4tZXYLP%2BuBedlvkRcNXP1xuvWIKstyMFR1WA6u3p52U%3D&reserved=0>, or unsubscribe<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQNNN6WGU3O3VXRBHHXER33W3AKYBANCNFSM6AAAAAAVTK62DI&data=05%7C01%7Czbangqi%40vmware.com%7C53578e19c68a43ff397f08db1f968dee%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C638138503730198560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=LbFU0L087WBhH4BScZtWMvYQBw3ozt68I8MsYztybC8%3D&reserved=0>.
You are receiving this because you were assigned.Message ID: ***@***.***>
!! External Email: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender.
|
|
Hi Jianjun, I got how to use this mirroring controller, since it are some changes between ClusterProperty and ClusterClaim, like Well known properties and apiVersion, I think I need about 3-4 weeks to deal with this issue, after this maybe there will be some changes but won’t block me from other issues.
Thanks!
Bangqi
From: Jianjun Shen ***@***.***>
Date: Tuesday, March 14, 2023 at 11:16 AM
To: Krishna Miriyala ***@***.***>, Bangqi Zhu ***@***.***>, antrea-io/antrea ***@***.***>, Akshay Katrekar ***@***.***>, Lan Luo ***@***.***>
Subject: Re: [antrea-io/antrea] Migrate ClusterClaim to ClusterProperty (Issue #4686)
Ideally, we should do mirroring of CRDs - using a mirroring controller to convert old CRDs to new ones, and other code just handles new CRDs. You can check the following PRs to learn more:
Remove all legacy (*.antrea.tanzu.vmware.com) APIs by antoninbas · Pull Request #3299 · antrea-io/antrea (github.com)<#3299>
Rename API groups from *.antrea.tanzu.vmware.com to *.antrea.io by hongliangl · Pull Request #1799 · antrea-io/antrea (github.com)<#1799>
However, I did not look into ClusterProperty to know if it is easy to be mirrored to ClusterClaim. Could you evaluate the approach?
In any case, I feel we could just support the new CRDs with antctl, and document only the new CRDs in documentation. Users can switch to old version antctl/documents for old CRDs.
Jianjun
…________________________________
From: Krishna Miriyala ***@***.***>
Sent: Tuesday, March 14, 2023 8:14
To: Bangqi Zhu ***@***.***>; antrea-io/antrea ***@***.***>; Akshay Katrekar ***@***.***>; Jianjun Shen ***@***.***>; Lan Luo ***@***.***>
Cc: Lan Luo ***@***.***>; Jianjun Shen ***@***.***>
Subject: Re: [antrea-io/antrea] Migrate ClusterClaim to ClusterProperty (Issue #4686)
@jianjun ***@***.***>/ @lan ***@***.***> Could you please direct @bangqi ***@***.***> for the right approach?
Get Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: Bangqi Zhu ***@***.***>
Sent: Monday, March 13, 2023 10:55:36 PM
To: antrea-io/antrea ***@***.***>; Akshay Katrekar ***@***.***>; Krishna Miriyala ***@***.***>
Cc: Lan Luo ***@***.***>; Jianjun Shen ***@***.***>
Subject: Re: [antrea-io/antrea] Migrate ClusterClaim to ClusterProperty (Issue #4686)
Hi,
Here is the cope of move ClusterClaim to ClusterProperty issue:
1. Docs: docs/multicluster docs
2. Designed the new ClusterProperty which conforms to the requirements, and the generated codes
3. New ClusterProperty webhook and its unit-tests. If we want support both ClusterClaim and ClusterProperty,
we also need a convert here.
4. Multicluster/build yamls and config yamls
5. Multicluster/controllers of ClustersetController in both Leaders and Members, MemberClusterAnnounceController, ClusterProperty itself Controller.
6. Pkg/client versioned informers and listers, which can be generated automatically
7. Integration’s test codes and yamls
8. Antctl ’s destroy command, init command, join command, cleanup command, deploy leader cluster command and deploy member cluster command, and the common file. And change the test files. If we want support both ClusterClaim and ClusterProperty, we need to find a way to deal with two CRD here.
The biggest variable now is whether we should support both versions, if the answer is yes, what approach we should take. We should convert the old ClusterClaim forcefully or not, if we support both version, do we want two CRDs running in the same cluster? Do we want the users to run the migrate code to ClusterClaim to ClusterProperty at last? I think a discussion should be done if we want to do this.
Thanks,
Bangqi
From: Lan ***@***.***>
Date: Tuesday, March 7, 2023 at 9:32 PM
To: antrea-io/antrea ***@***.***>
Cc: Bangqi Zhu ***@***.***>, Assign ***@***.***>
Subject: [antrea-io/antrea] Migrate ClusterClaim to ClusterProperty (Issue #4686)
!! External Email
Describe what you are trying to solve
Antrea Multi-cluster is using ClusterClaim CRD to allow user to claim a cluster in a ClusterSet. We was following the definition in KEP2149<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkubernetes%2Fenhancements%2Ftree%2Fmaster%2Fkeps%2Fsig-multicluster%2F2149-clusterid&data=05%7C01%7Czbangqi%40vmware.com%7C53578e19c68a43ff397f08db1f968dee%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C638138503730198560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=V9L3xWhPKurefj8yXHDH51U9630xYBoqSOlSMC8%2BwSM%3D&reserved=0>, but the CRD is changed from ClusterClaim to ClusterProperty, ClusterClaim is no longer used in upstream. It's better to follow upstream definition in Antrea Multi-cluster.
Describe the solution you have in mind
1. Remove ClusterClaim and add ClusterProperty CRD.
2. Support both ClusterClaim and ClusterProperty CRDs (preferred).
Describe how your solution impacts user flows
This will impact the way how to initialize a ClusterSet from user perspective. We should cover following cases when we do MC controllers refinement.
1. Migrate existing ClusterClaim to ClusterProperty and watch ClusterProperty change and update only after migration
2. ClusterProperty controller should cover all current ClusterClaim's use case.
—
Reply to this email directly, view it on GitHub<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fantrea-io%2Fantrea%2Fissues%2F4686&data=05%7C01%7Czbangqi%40vmware.com%7C53578e19c68a43ff397f08db1f968dee%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C638138503730198560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4tZXYLP%2BuBedlvkRcNXP1xuvWIKstyMFR1WA6u3p52U%3D&reserved=0>, or unsubscribe<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQNNN6WGU3O3VXRBHHXER33W3AKYBANCNFSM6AAAAAAVTK62DI&data=05%7C01%7Czbangqi%40vmware.com%7C53578e19c68a43ff397f08db1f968dee%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C638138503730198560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=LbFU0L087WBhH4BScZtWMvYQBw3ozt68I8MsYztybC8%3D&reserved=0>.
You are receiving this because you were assigned.Message ID: ***@***.***>
!! External Email: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender.
|
|
Sounds good. I would suggest to consider several smaller PRs which are easier to review.
Jianjun
…________________________________
From: Bangqi Zhu ***@***.***>
Sent: Wednesday, March 15, 2023 2:23
To: Jianjun Shen ***@***.***>; Krishna Miriyala ***@***.***>; antrea-io/antrea ***@***.***>; Akshay Katrekar ***@***.***>; Lan Luo ***@***.***>
Subject: Re: [antrea-io/antrea] Migrate ClusterClaim to ClusterProperty (Issue #4686)
Hi Jianjun, I got how to use this mirroring controller, since it are some changes between ClusterProperty and ClusterClaim, like Well known properties and apiVersion, I think I need about 3-4 weeks to deal with this issue, after this maybe there will be some changes but won’t block me from other issues.
Thanks!
Bangqi
From: Jianjun Shen ***@***.***>
Date: Tuesday, March 14, 2023 at 11:16 AM
To: Krishna Miriyala ***@***.***>, Bangqi Zhu ***@***.***>, antrea-io/antrea ***@***.***>, Akshay Katrekar ***@***.***>, Lan Luo ***@***.***>
Subject: Re: [antrea-io/antrea] Migrate ClusterClaim to ClusterProperty (Issue #4686)
Ideally, we should do mirroring of CRDs - using a mirroring controller to convert old CRDs to new ones, and other code just handles new CRDs. You can check the following PRs to learn more:
Remove all legacy (*.antrea.tanzu.vmware.com) APIs by antoninbas · Pull Request #3299 · antrea-io/antrea (github.com)<#3299>
Rename API groups from *.antrea.tanzu.vmware.com to *.antrea.io by hongliangl · Pull Request #1799 · antrea-io/antrea (github.com)<#1799>
However, I did not look into ClusterProperty to know if it is easy to be mirrored to ClusterClaim. Could you evaluate the approach?
In any case, I feel we could just support the new CRDs with antctl, and document only the new CRDs in documentation. Users can switch to old version antctl/documents for old CRDs.
Jianjun
________________________________
From: Krishna Miriyala ***@***.***>
Sent: Tuesday, March 14, 2023 8:14
To: Bangqi Zhu ***@***.***>; antrea-io/antrea ***@***.***>; Akshay Katrekar ***@***.***>; Jianjun Shen ***@***.***>; Lan Luo ***@***.***>
Cc: Lan Luo ***@***.***>; Jianjun Shen ***@***.***>
Subject: Re: [antrea-io/antrea] Migrate ClusterClaim to ClusterProperty (Issue #4686)
@jianjun ***@***.***>/ @lan ***@***.***> Could you please direct @bangqi ***@***.***> for the right approach?
Get Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: Bangqi Zhu ***@***.***>
Sent: Monday, March 13, 2023 10:55:36 PM
To: antrea-io/antrea ***@***.***>; Akshay Katrekar ***@***.***>; Krishna Miriyala ***@***.***>
Cc: Lan Luo ***@***.***>; Jianjun Shen ***@***.***>
Subject: Re: [antrea-io/antrea] Migrate ClusterClaim to ClusterProperty (Issue #4686)
Hi,
Here is the cope of move ClusterClaim to ClusterProperty issue:
1. Docs: docs/multicluster docs
2. Designed the new ClusterProperty which conforms to the requirements, and the generated codes
3. New ClusterProperty webhook and its unit-tests. If we want support both ClusterClaim and ClusterProperty,
we also need a convert here.
4. Multicluster/build yamls and config yamls
5. Multicluster/controllers of ClustersetController in both Leaders and Members, MemberClusterAnnounceController, ClusterProperty itself Controller.
6. Pkg/client versioned informers and listers, which can be generated automatically
7. Integration’s test codes and yamls
8. Antctl ’s destroy command, init command, join command, cleanup command, deploy leader cluster command and deploy member cluster command, and the common file. And change the test files. If we want support both ClusterClaim and ClusterProperty, we need to find a way to deal with two CRD here.
The biggest variable now is whether we should support both versions, if the answer is yes, what approach we should take. We should convert the old ClusterClaim forcefully or not, if we support both version, do we want two CRDs running in the same cluster? Do we want the users to run the migrate code to ClusterClaim to ClusterProperty at last? I think a discussion should be done if we want to do this.
Thanks,
Bangqi
From: Lan ***@***.***>
Date: Tuesday, March 7, 2023 at 9:32 PM
To: antrea-io/antrea ***@***.***>
Cc: Bangqi Zhu ***@***.***>, Assign ***@***.***>
Subject: [antrea-io/antrea] Migrate ClusterClaim to ClusterProperty (Issue #4686)
!! External Email
Describe what you are trying to solve
Antrea Multi-cluster is using ClusterClaim CRD to allow user to claim a cluster in a ClusterSet. We was following the definition in KEP2149<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkubernetes%2Fenhancements%2Ftree%2Fmaster%2Fkeps%2Fsig-multicluster%2F2149-clusterid&data=05%7C01%7Czbangqi%40vmware.com%7C53578e19c68a43ff397f08db1f968dee%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C638138503730198560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=V9L3xWhPKurefj8yXHDH51U9630xYBoqSOlSMC8%2BwSM%3D&reserved=0>, but the CRD is changed from ClusterClaim to ClusterProperty, ClusterClaim is no longer used in upstream. It's better to follow upstream definition in Antrea Multi-cluster.
Describe the solution you have in mind
1. Remove ClusterClaim and add ClusterProperty CRD.
2. Support both ClusterClaim and ClusterProperty CRDs (preferred).
Describe how your solution impacts user flows
This will impact the way how to initialize a ClusterSet from user perspective. We should cover following cases when we do MC controllers refinement.
1. Migrate existing ClusterClaim to ClusterProperty and watch ClusterProperty change and update only after migration
2. ClusterProperty controller should cover all current ClusterClaim's use case.
—
Reply to this email directly, view it on GitHub<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fantrea-io%2Fantrea%2Fissues%2F4686&data=05%7C01%7Czbangqi%40vmware.com%7C53578e19c68a43ff397f08db1f968dee%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C638138503730198560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4tZXYLP%2BuBedlvkRcNXP1xuvWIKstyMFR1WA6u3p52U%3D&reserved=0>, or unsubscribe<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQNNN6WGU3O3VXRBHHXER33W3AKYBANCNFSM6AAAAAAVTK62DI&data=05%7C01%7Czbangqi%40vmware.com%7C53578e19c68a43ff397f08db1f968dee%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C638138503730198560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=LbFU0L087WBhH4BScZtWMvYQBw3ozt68I8MsYztybC8%3D&reserved=0>.
You are receiving this because you were assigned.Message ID: ***@***.***>
!! External Email: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender.
|
|
We decide to remove ClusterClaim to simplify ClusterSet setup, so close this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe what you are trying to solve
Antrea Multi-cluster is using
ClusterClaimCRD to allow user to claim a cluster in a ClusterSet. We was following the definition in KEP2149, but the CRD is changed fromClusterClaimtoClusterProperty,ClusterClaimis no longer used in upstream. It's better to follow upstream definition in Antrea Multi-cluster.Describe the solution you have in mind
ClusterClaimand addClusterPropertyCRD.ClusterClaimandClusterPropertyCRDs (preferred).Describe how your solution impacts user flows
This will impact the way how to initialize a ClusterSet from user perspective. We should cover following cases when we do MC controllers refinement.
ClusterPropertychange and update only after migrationThe text was updated successfully, but these errors were encountered: