-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set kubelet's cgroup driver to groupfs in playbook #2883
Conversation
In v1.22, if the user is not setting the cgroupDriver field under KubeletConfiguration, kubeadm will default it to systemd. Signed-off-by: Hang Yan <yhang@vmware.com>
/assign lzhecheng |
Codecov Report
@@ Coverage Diff @@
## main #2883 +/- ##
==========================================
- Coverage 60.30% 58.50% -1.80%
==========================================
Files 283 283
Lines 23504 23504
==========================================
- Hits 14173 13750 -423
- Misses 7797 8275 +478
+ Partials 1534 1479 -55
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you clarify why this change is needed:
- what breaks without this change?
- the K8s documentation recommends using systemd, so why don't we try to get systemd to work instead?
Sorry my comment was not clear before.
|
@hangyan I think that's in part where my confusion comes from. The playbook has already been updated a couple of months ago to use containerd instead of docker: #2583. So we are not using docker anymore. And before we switched to containerd, we had already updated the playbook to make docker use systemd: #2543 |
Sorry i miss that. I was using a downstream project which contains ref to the old antrea version which is before #2543. Thanks for the explaination. Will update downstream code and close this PR now. |
In v1.22, if the user is not setting the cgroupDriver field under
KubeletConfiguration, kubeadm will default it to systemd.
Signed-off-by: Hang Yan yhang@vmware.com