Switch vagrant test cluster runtime to use containerd directly #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
reviewed
Aug 12, 2021
test/e2e/infra/vagrant/playbook/roles/common/tasks/containerd.yml
Outdated
Show resolved
Hide resolved
test/e2e/infra/vagrant/playbook/roles/common/tasks/containerd.yml
Outdated
Show resolved
Hide resolved
test/e2e/infra/vagrant/playbook/roles/common/tasks/containerd.yml
Outdated
Show resolved
Hide resolved
test/e2e/infra/vagrant/playbook/roles/common/tasks/containerd.yml
Outdated
Show resolved
Hide resolved
test/e2e/infra/vagrant/playbook/roles/common/templates/99-kubernetes-cri.conf.j2
Outdated
Show resolved
Hide resolved
stanleywbwong
force-pushed
the
replace-test-runtime
branch
2 times, most recently
from
33fabc9
to
0397fd0
Compare
antoninbas
reviewed
Aug 12, 2021
test/e2e/infra/vagrant/playbook/roles/common/templates/containerd.conf.j2
Outdated
Show resolved
Hide resolved
test/e2e/infra/vagrant/playbook/roles/common/templates/containerd.conf.j2
Show resolved
Hide resolved
stanleywbwong
force-pushed
the
replace-test-runtime
branch
from
0397fd0
to
a0365ae
Compare
Signed-off-by: Stan Wong <swong394@gmail.com>
stanleywbwong
force-pushed
the
replace-test-runtime
branch
from
a0365ae
to
d3a2f11
Compare
|
/skip-all |
|
@tnqn @lzhecheng @srikartati and others, any objection to this change? |
Codecov Report
@@ Coverage Diff @@
## main #2583 +/- ##
==========================================
+ Coverage 60.18% 60.22% +0.04%
==========================================
Files 281 282 +1
Lines 22257 22411 +154
==========================================
+ Hits 13396 13498 +102
- Misses 7439 7486 +47
- Partials 1422 1427 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
srikartati
approved these changes
Aug 17, 2021
Comment on lines
+35
to
+40
| [plugins.scheduler] | ||
| pause_threshold = 0.02 | ||
| deletion_threshold = 0 | ||
| mutation_threshold = 100 | ||
| schedule_delay = 0 | ||
| startup_delay = "100ms" |
There was a problem hiding this comment.
Out of curiosity. How are these values picked? Is there any recommended configuartion?
There was a problem hiding this comment.
It's a default configuration I grabbed from https://github.com/containerd/containerd/blob/main/docs/man/containerd-config.toml.5.md
|
I tested the latest version locally and confirmed that it works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2545
Signed-off-by: Stan Wong swong394@gmail.com