-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch vagrant test cluster runtime to use containerd directly #2583
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. I left a few comments. I will test the PR after these are addressed.
test/e2e/infra/vagrant/playbook/roles/common/tasks/containerd.yml
Outdated
Show resolved
Hide resolved
test/e2e/infra/vagrant/playbook/roles/common/tasks/containerd.yml
Outdated
Show resolved
Hide resolved
test/e2e/infra/vagrant/playbook/roles/common/tasks/containerd.yml
Outdated
Show resolved
Hide resolved
test/e2e/infra/vagrant/playbook/roles/common/tasks/containerd.yml
Outdated
Show resolved
Hide resolved
test/e2e/infra/vagrant/playbook/roles/common/templates/99-kubernetes-cri.conf.j2
Outdated
Show resolved
Hide resolved
33fabc9
to
0397fd0
Compare
test/e2e/infra/vagrant/playbook/roles/common/templates/containerd.conf.j2
Outdated
Show resolved
Hide resolved
test/e2e/infra/vagrant/playbook/roles/common/templates/containerd.conf.j2
Show resolved
Hide resolved
0397fd0
to
a0365ae
Compare
Signed-off-by: Stan Wong <swong394@gmail.com>
a0365ae
to
d3a2f11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/skip-all |
@tnqn @lzhecheng @srikartati and others, any objection to this change? |
Codecov Report
@@ Coverage Diff @@
## main #2583 +/- ##
==========================================
+ Coverage 60.18% 60.22% +0.04%
==========================================
Files 281 282 +1
Lines 22257 22411 +154
==========================================
+ Hits 13396 13498 +102
- Misses 7439 7486 +47
- Partials 1422 1427 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
No objection. It seems docker runtime production support is removed in K8s v1.22.
[plugins.scheduler] | ||
pause_threshold = 0.02 | ||
deletion_threshold = 0 | ||
mutation_threshold = 100 | ||
schedule_delay = 0 | ||
startup_delay = "100ms" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity. How are these values picked? Is there any recommended configuartion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a default configuration I grabbed from https://github.com/containerd/containerd/blob/main/docs/man/containerd-config.toml.5.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I tested the latest version locally and confirmed that it works |
Fixes #2545
Signed-off-by: Stan Wong swong394@gmail.com