Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #2695: Wait for ovs-vswitchd PID before calling ovs-appctl #2711

Conversation

tnqn
Copy link
Member

@tnqn tnqn commented Sep 2, 2021

Cherry pick of #2695 on release-1.3.

#2695: Wait for ovs-vswitchd PID before calling ovs-appctl

For details on the cherry pick process, see the cherry pick requests page.

Otherwise the call may fail and crash the process.

Besides, it cleans up the OVS run files on exit to avoid stale PID
from being used.

Signed-off-by: Quan Tian <qtian@vmware.com>
@tnqn tnqn added the kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release label Sep 2, 2021
@tnqn
Copy link
Member Author

tnqn commented Sep 2, 2021

/test-all

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2021

Codecov Report

Merging #2711 (ab950f5) into release-1.3 (b8a6983) will decrease coverage by 0.02%.
The diff coverage is 46.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.3    #2711      +/-   ##
===============================================
- Coverage        60.68%   60.66%   -0.03%     
===============================================
  Files              285      285              
  Lines            23020    23032      +12     
===============================================
+ Hits             13970    13972       +2     
- Misses            7551     7552       +1     
- Partials          1499     1508       +9     
Flag Coverage Δ
e2e-tests ∅ <ø> (?)
kind-e2e-tests 48.36% <46.66%> (-0.06%) ⬇️
unit-tests 41.00% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/ovs/ovsctl/interface.go 0.00% <0.00%> (ø)
pkg/ovs/ovsctl/ovsctl_others.go 52.00% <50.00%> (+2.00%) ⬆️
pkg/controller/networkpolicy/store/addressgroup.go 83.01% <0.00%> (-3.78%) ⬇️
...gent/controller/networkpolicy/status_controller.go 72.60% <0.00%> (-2.74%) ⬇️
pkg/controller/networkpolicy/status_controller.go 73.20% <0.00%> (-1.97%) ⬇️
pkg/agent/util/iptables/iptables.go 36.87% <0.00%> (-1.42%) ⬇️
...kg/agent/flowexporter/connections/conntrack_ovs.go 76.36% <0.00%> (-1.22%) ⬇️
pkg/agent/memberlist/cluster.go 72.03% <0.00%> (+0.47%) ⬆️
pkg/monitor/controller.go 29.10% <0.00%> (+1.49%) ⬆️
pkg/apiserver/storage/ram/store.go 80.45% <0.00%> (+1.50%) ⬆️
... and 1 more

@tnqn tnqn merged commit 1ab926e into antrea-io:release-1.3 Sep 3, 2021
@tnqn tnqn deleted the automated-cherry-pick-of-#2695-upstream-release-1.3 branch September 3, 2021 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants