-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait for ovs-vswitchd PID before calling ovs-appctl #2695
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2695 +/- ##
==========================================
+ Coverage 59.50% 65.67% +6.17%
==========================================
Files 285 285
Lines 23020 26380 +3360
==========================================
+ Hits 13697 17326 +3629
+ Misses 7865 7437 -428
- Partials 1458 1617 +159
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test-all |
What code at agent startup runs appctl? Why it crashes? Should we just retry there instead? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It's a step that validates whether OVS supports NAT. The linked issue #2694 has the detail of the problem. |
Otherwise the call may fail and crash the process. Besides, it cleans up the OVS run files on exit to avoid stale PID from being used. Signed-off-by: Quan Tian <qtian@vmware.com>
/test-all |
@antoninbas I found I never got the expected "Waited for" log when verifying the change and it still crashed sometimes, which was because I was checking the condition func's return value |
Otherwise the call may fail and crash the process.
Besides, it cleans up the OVS run files on exit to avoid stale PID
from being used.
Signed-off-by: Quan Tian qtian@vmware.com
Fixes #2694