Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #2555: Handle iptables-restore failures correctly in NPL #2575

Conversation

antoninbas
Copy link
Contributor

Cherry pick of #2555 on release-1.2.

#2555: Handle iptables-restore failures correctly in NPL

For details on the cherry pick process, see the cherry pick requests page.

Add a retry mechanism in the Controller initialization, which will keep
trying to sync iptables rules until the operation is successful. On
success, the NPL Controller is notified through a channel and can start
its event handlers.

Fixes antrea-io#2554

Signed-off-by: Antonin Bas <abas@vmware.com>
Signed-off-by: Antonin Bas <abas@vmware.com>
Signed-off-by: Antonin Bas <abas@vmware.com>
@antoninbas antoninbas added the kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release label Aug 11, 2021
@antoninbas antoninbas requested a review from tnqn August 11, 2021 16:47
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2021

Codecov Report

Merging #2575 (a83d550) into release-1.2 (65d836a) will increase coverage by 0.04%.
The diff coverage is 68.42%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.2    #2575      +/-   ##
===============================================
+ Coverage        59.99%   60.03%   +0.04%     
===============================================
  Files              284      284              
  Lines            22297    22311      +14     
===============================================
+ Hits             13376    13394      +18     
+ Misses            7489     7488       -1     
+ Partials          1432     1429       -3     
Flag Coverage Δ
e2e-tests ∅ <ø> (?)
kind-e2e-tests 46.98% <68.42%> (-0.01%) ⬇️
unit-tests 42.35% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/nodeportlocal/k8s/npl_controller.go 59.31% <61.90%> (+0.68%) ⬆️
pkg/agent/nodeportlocal/portcache/port_table.go 63.15% <76.47%> (+1.42%) ⬆️
pkg/apiserver/handlers/endpoint/handler.go 58.82% <0.00%> (-11.77%) ⬇️
pkg/agent/controller/networkpolicy/reconciler.go 76.81% <0.00%> (-0.24%) ⬇️
pkg/agent/cniserver/pod_configuration.go 54.68% <0.00%> (+0.78%) ⬆️
pkg/apiserver/storage/ram/store.go 80.45% <0.00%> (+1.50%) ⬆️
pkg/controller/grouping/controller.go 68.96% <0.00%> (+1.72%) ⬆️
pkg/agent/flowexporter/connections/connections.go 82.22% <0.00%> (+6.66%) ⬆️

@antoninbas
Copy link
Contributor Author

/test-all

@antoninbas antoninbas merged commit 507a108 into antrea-io:release-1.2 Aug 11, 2021
@antoninbas antoninbas deleted the automated-cherry-pick-of-#2555-upstream-release-1.2 branch August 11, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants