Handle iptables-restore failures correctly in NPL Controller #2555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2555 +/- ##
==========================================
+ Coverage 60.09% 65.01% +4.92%
==========================================
Files 281 281
Lines 22243 25524 +3281
==========================================
+ Hits 13366 16594 +3228
+ Misses 7467 7391 -76
- Partials 1410 1539 +129
Flags with carried forward coverage won't be shown. Click here to find out more.
|
monotosh-avi
previously approved these changes
Aug 9, 2021
|
/test-all |
tnqn
reviewed
Aug 10, 2021
| @@ -117,6 +119,14 @@ func podKeyFunc(pod *corev1.Pod) string { | |||
| return pod.Namespace + "/" + pod.Name | |||
| } | |||
|
|
|||
| func (c *NPLController) Initialize() error { | |||
| klog.InfoS("Will fetch Pods and generate NodePortLocal rules for these Pods") | |||
| if err := c.GetPodsAndGenRules(); err != nil { | |||
There was a problem hiding this comment.
After it's extracted to a method and called separately, it doesn't wait for cache to sync, I think it may miss Pod data?
Add a retry mechanism in the Controller initialization, which will keep trying to sync iptables rules until the operation is successful. On success, the NPL Controller is notified through a channel and can start its event handlers. Fixes antrea-io#2554 Signed-off-by: Antonin Bas <abas@vmware.com>
Signed-off-by: Antonin Bas <abas@vmware.com>
antoninbas
force-pushed
the
handle-iptables-restore-failures-in-NPL-controller
branch
from
c08cb85
to
d366acc
Compare
|
@tnqn thanks for the review. I believe you are right about the cache. I pushed a second commit to address it. Please let me know if you have a more elegant solution to suggest. |
|
/test-e2e |
Signed-off-by: Antonin Bas <abas@vmware.com>
|
/test-all |
antoninbas
deleted the
handle-iptables-restore-failures-in-NPL-controller
branch
antoninbas
added a commit
that referenced
this pull request
Aug 11, 2021
…ectly in NPL (#2575) Add a retry mechanism in the Controller initialization, which will keep trying to sync iptables rules until the operation is successful. On success, the NPL Controller is notified through a channel and can start its event handlers. Fixes #2554 Signed-off-by: Antonin Bas <abas@vmware.com>
annakhm
pushed a commit
to annakhm/antrea
that referenced
this pull request
Aug 16, 2021
…io#2555) Add a retry mechanism in the Controller initialization, which will keep trying to sync iptables rules until the operation is successful. On success, the NPL Controller is notified through a channel and can start its event handlers. Fixes antrea-io#2554 Signed-off-by: Antonin Bas <abas@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a retry mechanism in the Controller initialization, which will keep
trying to sync iptables rules until the operation is successful. On
success, the NPL Controller is notified through a channel and can start
its event handlers.
Fixes #2554
Signed-off-by: Antonin Bas abas@vmware.com