Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8497/f0940d82 backport][stable-8] homectl, udm_user: guard crypt imports #8498

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jun 13, 2024

This is a backport of PR #8497 as merged into main (f0940d8).

SUMMARY

Now that ansible-core devel's ansible-test also tests with Python 3.13, in which the crypt standard library module has been removed, we have to do something about these two modules using that part of the standard library.

This PR makes the crypt import guarded and lets the module fail with an expressive error message. It would be better to get rid of the crypt usages, but that's for someone else...

Ref: #4691
Ref: #4690

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

homectl
udm_user

Guard crypt import.

(cherry picked from commit f0940d8)
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type) labels Jun 13, 2024
@felixfontein felixfontein merged commit 9315a7b into stable-8 Jun 13, 2024
131 checks passed
@felixfontein felixfontein deleted the patchback/backports/stable-8/f0940d82dc53f843e598d073a7ed102f8e50e628/pr-8497 branch June 13, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants