homectl, udm_user: guard crypt imports #8497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
added
backport-8
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #8498 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 13, 2024
Guard crypt import. (cherry picked from commit f0940d8)
Backport to stable-9: 💚 backport PR created✅ Backport PR branch: Backported as #8499 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 13, 2024
Guard crypt import. (cherry picked from commit f0940d8)
felixfontein
added a commit
that referenced
this pull request
Jun 13, 2024
felixfontein
added a commit
that referenced
this pull request
Jun 13, 2024
Massl123
pushed a commit
to Massl123/community.general
that referenced
this pull request
Feb 7, 2025
Guard crypt import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Now that ansible-core devel's ansible-test also tests with Python 3.13, in which the crypt standard library module has been removed, we have to do something about these two modules using that part of the standard library.
This PR makes the crypt import guarded and lets the module fail with an expressive error message. It would be better to get rid of the crypt usages, but that's for someone else...
Ref: #4691
Ref: #4690
ISSUE TYPE
COMPONENT NAME
homectl
udm_user