Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ec2_ami* modules #2164

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Refactor ec2_ami* modules #2164

merged 2 commits into from
Jul 4, 2024

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Jul 1, 2024

SUMMARY

Refactor ec2_ami,ec2_ami_info modules

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_ami ec2_ami_info

@abikouo abikouo force-pushed the refactor-modules-ec2_ami-2401071443 branch from bf603d3 to eeab947 Compare July 1, 2024 14:43
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/df7a75d1239e4d20bb1e34fa8df167da

✔️ ansible-galaxy-importer SUCCESS in 3m 25s
✔️ build-ansible-collection SUCCESS in 12m 16s
✔️ ansible-test-splitter SUCCESS in 4m 59s
❌ integration-amazon.aws-1 FAILURE in 8m 52s
❌ integration-amazon.aws-2 FAILURE in 4m 42s
❌ integration-amazon.aws-3 FAILURE in 7m 56s
Skipped 41 jobs

@abikouo abikouo force-pushed the refactor-modules-ec2_ami-2401071443 branch from 533dc4c to ad2dbab Compare July 2, 2024 14:52
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/363f4cf7425b424c8170798fa2c338fd

✔️ ansible-galaxy-importer SUCCESS in 5m 06s
✔️ build-ansible-collection SUCCESS in 12m 41s
✔️ ansible-test-splitter SUCCESS in 4m 58s
❌ integration-amazon.aws-1 FAILURE in 4m 21s
❌ integration-amazon.aws-2 FAILURE in 7m 56s
❌ integration-amazon.aws-3 FAILURE in 5m 36s
Skipped 41 jobs

alinabuzachis
alinabuzachis approved these changes Jul 3, 2024
View reviewed changes
plugins/modules/ec2_ami.py Outdated Show resolved Hide resolved
plugins/modules/ec2_ami.py Outdated Show resolved Hide resolved
plugins/modules/ec2_ami.py Outdated Show resolved Hide resolved
plugins/modules/ec2_ami.py Outdated Show resolved Hide resolved
plugins/modules/ec2_ami.py Outdated Show resolved Hide resolved
plugins/modules/ec2_ami.py Outdated Show resolved Hide resolved
plugins/modules/ec2_ami.py Outdated Show resolved Hide resolved
plugins/modules/ec2_ami_info.py Outdated Show resolved Hide resolved
plugins/modules/ec2_ami_info.py Outdated Show resolved Hide resolved
plugins/modules/ec2_ami_info.py Outdated Show resolved Hide resolved
@abikouo abikouo force-pushed the refactor-modules-ec2_ami-2401071443 branch from ad2dbab to ba4aa9f Compare July 3, 2024 13:02
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/738f76b5064e465daaf05905f7b71434

✔️ ansible-galaxy-importer SUCCESS in 4m 46s
✔️ build-ansible-collection SUCCESS in 12m 16s
✔️ ansible-test-splitter SUCCESS in 4m 57s
❌ integration-amazon.aws-1 FAILURE in 5m 13s
❌ integration-amazon.aws-2 FAILURE in 6m 02s
❌ integration-amazon.aws-3 FAILURE in 5m 40s
Skipped 41 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/f975ee2a6d114855937843d5311fe15c

✔️ ansible-galaxy-importer SUCCESS in 4m 38s
✔️ build-ansible-collection SUCCESS in 12m 44s
✔️ ansible-test-splitter SUCCESS in 5m 16s
❌ integration-amazon.aws-1 FAILURE in 11m 04s
❌ integration-amazon.aws-2 FAILURE in 5m 42s
❌ integration-amazon.aws-3 FAILURE in 5m 46s
❌ integration-amazon.aws-4 FAILURE in 5m 59s
Skipped 40 jobs

@abikouo abikouo force-pushed the refactor-modules-ec2_ami-2401071443 branch from 14e86ac to 75966e1 Compare July 4, 2024 10:57
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/efefff8d10f74bd1b9a2ff63b74a1afc

✔️ ansible-galaxy-importer SUCCESS in 4m 23s
✔️ build-ansible-collection SUCCESS in 12m 23s
✔️ ansible-test-splitter SUCCESS in 4m 54s
❌ integration-amazon.aws-1 FAILURE in 5m 59s
❌ integration-amazon.aws-2 FAILURE in 5m 53s
❌ integration-amazon.aws-3 FAILURE in 7m 39s
Skipped 41 jobs

@abikouo abikouo force-pushed the refactor-modules-ec2_ami-2401071443 branch from 75966e1 to b063c14 Compare July 4, 2024 12:20
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/8a9498d3bf1243c1b64663b71bfa243d

✔️ ansible-galaxy-importer SUCCESS in 4m 50s
✔️ build-ansible-collection SUCCESS in 12m 20s
✔️ ansible-test-splitter SUCCESS in 4m 52s
✔️ integration-amazon.aws-1 SUCCESS in 12m 21s
✔️ integration-amazon.aws-2 SUCCESS in 16m 43s
✔️ integration-amazon.aws-3 SUCCESS in 18m 32s
✔️ integration-amazon.aws-4 SUCCESS in 24m 15s
✔️ integration-amazon.aws-5 SUCCESS in 15m 26s
✔️ integration-amazon.aws-6 SUCCESS in 17m 34s
✔️ integration-amazon.aws-7 SUCCESS in 15m 02s
✔️ integration-amazon.aws-8 SUCCESS in 12m 14s
✔️ integration-amazon.aws-9 SUCCESS in 24m 02s
✔️ integration-amazon.aws-10 SUCCESS in 17m 05s
✔️ integration-amazon.aws-11 SUCCESS in 9m 59s
✔️ integration-amazon.aws-12 SUCCESS in 13m 11s
✔️ integration-amazon.aws-13 SUCCESS in 7m 42s
✔️ integration-amazon.aws-14 SUCCESS in 9m 24s
✔️ integration-amazon.aws-15 SUCCESS in 17m 37s
✔️ integration-amazon.aws-16 SUCCESS in 20m 46s
✔️ integration-amazon.aws-17 SUCCESS in 11m 30s
✔️ integration-amazon.aws-18 SUCCESS in 15m 02s
✔️ integration-amazon.aws-19 SUCCESS in 24m 45s
✔️ integration-amazon.aws-20 SUCCESS in 10m 35s
✔️ integration-community.aws-1 SUCCESS in 16m 53s
✔️ integration-community.aws-2 SUCCESS in 9m 52s
✔️ integration-community.aws-3 SUCCESS in 7m 59s
✔️ integration-community.aws-4 SUCCESS in 7m 21s
✔️ integration-community.aws-5 SUCCESS in 4m 58s
✔️ integration-community.aws-6 SUCCESS in 7m 05s
✔️ integration-community.aws-7 SUCCESS in 5m 16s
Skipped 17 jobs

@abikouo abikouo added the mergeit Merge the PR (SoftwareFactory) label Jul 4, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/32697dcfbc154cb9bc7313df07feb580

✔️ ansible-galaxy-importer SUCCESS in 4m 35s
✔️ build-ansible-collection SUCCESS in 12m 24s
✔️ ansible-test-splitter SUCCESS in 4m 56s
✔️ integration-amazon.aws-1 SUCCESS in 12m 45s
✔️ integration-amazon.aws-2 SUCCESS in 15m 53s
✔️ integration-amazon.aws-3 SUCCESS in 19m 09s
✔️ integration-amazon.aws-4 SUCCESS in 24m 29s
✔️ integration-amazon.aws-5 SUCCESS in 20m 17s
✔️ integration-amazon.aws-6 SUCCESS in 16m 35s
✔️ integration-amazon.aws-7 SUCCESS in 12m 47s
✔️ integration-amazon.aws-8 SUCCESS in 13m 46s
✔️ integration-amazon.aws-9 SUCCESS in 10m 23s
✔️ integration-amazon.aws-10 SUCCESS in 10m 47s
✔️ integration-amazon.aws-11 SUCCESS in 9m 35s
✔️ integration-amazon.aws-12 SUCCESS in 14m 21s
✔️ integration-amazon.aws-13 SUCCESS in 9m 28s
✔️ integration-amazon.aws-14 SUCCESS in 9m 39s
✔️ integration-amazon.aws-15 SUCCESS in 17m 03s
✔️ integration-amazon.aws-16 SUCCESS in 24m 11s
✔️ integration-amazon.aws-17 SUCCESS in 13m 14s
✔️ integration-amazon.aws-18 SUCCESS in 16m 09s
✔️ integration-amazon.aws-19 SUCCESS in 22m 15s
✔️ integration-amazon.aws-20 SUCCESS in 10m 33s
✔️ integration-community.aws-1 SUCCESS in 15m 09s
✔️ integration-community.aws-2 SUCCESS in 6m 36s
✔️ integration-community.aws-3 SUCCESS in 10m 12s
✔️ integration-community.aws-4 SUCCESS in 7m 31s
✔️ integration-community.aws-5 SUCCESS in 5m 36s
✔️ integration-community.aws-6 SUCCESS in 7m 06s
✔️ integration-community.aws-7 SUCCESS in 5m 05s
Skipped 17 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit f302c31 into ansible-collections:main Jul 4, 2024
35 of 37 checks passed
abikouo added a commit to abikouo/amazon.aws that referenced this pull request Oct 18, 2024
@abikouo
Prepare module ec2_launch_template for promotion (ansible-collections…
5902a20 
…#2164)

SUMMARY

Depends-On: ansible-collections#2319

Add some type hint for the module
Use shared code from amazon.aws.plugins.module_utils.ec2
Add the possibility to delete specific version of a launch template
Add support for tagging for launch template resource (Closes ansible-collections#176)
Add the possibility to tag specific resources, not always instance and volume (Closes [ansible-collections#48](ansible-collections#48, Closes ansible-collections#2083)
Support EBS Throughput (Closes ansible-collections#1944)
Fix issue occurring when launch template contains more than 200 versions (Closes ansible-collections#2131)

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ec2_launch_template

Reviewed-by: Alina Buzachis
Reviewed-by: Bikouo Aubin
Reviewed-by: GomathiselviS <gomathiselvi@gmail.com>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@40d61f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

Assignees
No one assigned
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abikouo @alinabuzachis