Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up test requirements #176

Merged
merged 2 commits into from
Oct 22, 2020
Merged

Conversation

jillr
Copy link
Contributor

@jillr jillr commented Oct 21, 2020

SUMMARY

We have unit test requirements from ansible/ansible that aren't needed for aws

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

tests/unit/requirements.txt

jillr added 2 commits October 21, 2020 20:41
We have unit test requirements from ansible/ansible that aren't needed for aws
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that's a lot of cruft we pulled over. No big surprise I guess.

@tremble tremble merged commit ace955f into ansible-collections:main Oct 22, 2020
@jillr jillr deleted the test_deps branch February 24, 2021 17:27
abikouo added a commit to abikouo/amazon.aws that referenced this pull request Oct 18, 2024
…#2164)

SUMMARY

Depends-On: ansible-collections#2319

Add some type hint for the module
Use shared code from amazon.aws.plugins.module_utils.ec2
Add the possibility to delete specific version of a launch template
Add support for tagging for launch template resource (Closes ansible-collections#176)
Add the possibility to tag specific resources, not always instance and volume (Closes [ansible-collections#48](ansible-collections#48, Closes ansible-collections#2083)
Support EBS Throughput (Closes ansible-collections#1944)
Fix issue occurring when launch template contains more than 200 versions (Closes ansible-collections#2131)

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ec2_launch_template

Reviewed-by: Alina Buzachis
Reviewed-by: Bikouo Aubin
Reviewed-by: GomathiselviS <gomathiselvi@gmail.com>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@40d61f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants