fix: refresh NoteEditor fields after restoring templates to default#20579
Open
qingfeng19491001 wants to merge 3 commits intoankidroid:mainfrom
Open
Conversation
david-allison
requested changes
Mar 25, 2026
Member
david-allison
left a comment
There was a problem hiding this comment.
Could you add a test?
This should ideally be handled by handling the opChanges result. Could you diagnose why this didn't cause a refresh?
Contributor
Author
No problem.I'll add a test and a cause to description of pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Fixes IndexOutOfBoundsException by refreshing NoteEditor fields after a template reset.And ensure the UI matches the new field count in the backend, preventing a crash on save.
Fixes
Approach
How Has This Been Tested?
Manually tested the dialog in the app on a physical device:

Device: realme RMX1991
reproduce actions of #20510
before
after
https://github.com/user-attachments/assets/bba850b5-2256-404c-a73f-71deaefb2e60
Checklist