Skip to content

Comments

chore: replace generic OK buttons with explicit action labels in dialogs#20263

Merged
BrayanDSO merged 3 commits intoankidroid:mainfrom
siddhesh-06:improve-positive-labels-dialog
Jan 30, 2026
Merged

chore: replace generic OK buttons with explicit action labels in dialogs#20263
BrayanDSO merged 3 commits intoankidroid:mainfrom
siddhesh-06:improve-positive-labels-dialog

Conversation

@siddhesh-06
Copy link
Contributor

Purpose / Description

Uses explicit action labels (e.g., "Create", "Rename", "Add") instead of "OK" to comply with Material 2 dialog guidelines.

  1. Replaced generic “OK” dialog buttons with explicit action labels like “Add”, “Create”, and “Rename”.
  2. Updated multiple dialogs to improve clarity and follow Material dialog guidelines.
  3. Centralized positive button text selection for deck dialogs based on dialog type.

Fixes

Screenshots

Before fix

Before dialog changes

After fix

After dialog changes

Approach

Replace OK labels with explicit action labels

How Has This Been Tested?

Tested on Pixel 9 OS 16 - emulator device

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the [Google Accessibility Scanner]

@BrayanDSO BrayanDSO added Needs Author Reply Waiting for a reply from the original author and removed Needs Review labels Jan 30, 2026
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny nitpick, then looks good to go for me

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FANTASTIC, cheers!

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Author Reply Waiting for a reply from the original author labels Jan 30, 2026
@BrayanDSO BrayanDSO added this pull request to the merge queue Jan 30, 2026
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jan 30, 2026
Merged via the queue into ankidroid:main with commit e20462e Jan 30, 2026
15 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jan 30, 2026
@github-actions github-actions bot added this to the 2.24 release milestone Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistnecies between dialog messages

3 participants