chore: replace generic OK buttons with explicit action labels in dialogs#20263
Merged
BrayanDSO merged 3 commits intoankidroid:mainfrom Jan 30, 2026
Merged
Conversation
BrayanDSO
requested changes
Jan 30, 2026
AnkiDroid/src/main/java/com/ichi2/anki/dialogs/CreateDeckDialog.kt
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/dialogs/CreateDeckDialog.kt
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/dialogs/CreateDeckDialog.kt
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/dialogs/CreateDeckDialog.kt
Outdated
Show resolved
Hide resolved
Member
david-allison
left a comment
There was a problem hiding this comment.
One tiny nitpick, then looks good to go for me
AnkiDroid/src/main/java/com/ichi2/anki/dialogs/CreateDeckDialog.kt
Outdated
Show resolved
Hide resolved
BrayanDSO
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Uses explicit action labels (e.g., "Create", "Rename", "Add") instead of "OK" to comply with Material 2 dialog guidelines.
Fixes
Screenshots
Before fix
After fix
Approach
Replace OK labels with explicit action labels
How Has This Been Tested?
Tested on Pixel 9 OS 16 - emulator device
Checklist
Please, go through these checks before submitting the PR.