Inconsistnecies between dialog messages

[ZornHadNoChoice]

Below is a list of all the dialogs (as far as I know) that need changes.

Note

• When I say, red text, I mean like the one shown above plus the "!" icon.
• When I say a border with text in it, I mean like the "New name:" in the border of the box in the last screenshot.
• See the second image for examples of what I mean by "Update background color" and "unit".
• Some of these changes are just suggestions. For example, "OK" can be acceptable sometimes.
• I included review reminders for good measure.
• Feel free to edit this however you like.

• Decide which numeric dialogs should be changed to input steppers (like in Improve UI of IncrementerNumberRangePreferenceCompat #20005).

---

Settings

• Minutes between automatic backups:
  • Change to input stepper (Improve UI of IncrementerNumberRangePreferenceCompat #20005).
• Daily backups to keep:
  • Same as above.
• Weekly backups to keep:
  • Same as above.
• Monthly backups to keep:
  • Same as above.
• Network timeout:
  • Same as above.

Decks

• Create filtered deck:
  • Show red text if a filtered deck or a normal deck with the same name exists, and disable the button.
• Rename deck:
  • If you try to change the casing (upper vs lower), it will show the "Deck already exists" warning.

Browser

• Add tag:
  • Show red text if the tag already exists and disable the button.
• Set due date:
  • Limit the number.
• Reposition new cards:
  • Text at the top says "Queue top:" twice, which doesn't make sense.
  • Limit the number.
  • If the boxes are empty, the button should be disabled.

Managing fields

• Add field:
  • Show red text if field already exists and disable the button.
• Rename field:
  • Same as above.

Note/card types

• Add note type:
  • Show red text if note type already exists.
• Rename note type:
  • Same as above.
• Rename card type:
  • Show red text if the card type already exists and disable the button.

Reminders

• Edit review reminder:
  • Limit the number of digits.
  • Remove the red text "Please enter a whole number of cards".
  • If the box is empty, the button should be disabled, instead of showing the toast "Something went wrong, please try again".
• Add review reminder:
  • Same as above.

---

Low priority

Settings

• Learn ahead limit:
  • Replace "OK" with a more useful string.
  • Update background color.
  • Add a border to the box.
  • Add a unit "minute"/"minutes" to the box.
• Timebox time limit:
  • Same as above.

---

• Language:
  • Update background color.
• Error reporting mode:
  • Update background color.
• Deck for new cards:
  • Update background color.
• Frame style:
  • Update background color.
• Hide system bars:
  • Update background color.
• Toolbar position:
  • Update background color.
• Fetch media on sync
  • Update background color.
• Theme:
  • Update background color.
• Day theme:
  • Update background color.
• Night theme:
  • Update background color.
• Remove background?:
  • Update background color.
  • Consider removing the "?" and adding a text like "Are you sure you want to remove the background image?".
• The million dialog messages in the Controls category!
  • There are gesture/key/joystick dialogs, dialogs for choosing the side and another dialog specificly for answer actions.
  • Update background color and match the other dialogs.

---

• Sync url:
  • Replace "OK" with a more useful string.
  • Update background color.
  • Add a border to the box.
• Custom root certificate (PEM):
  • Same as above.
• AnkiDroid directory:
  • Same as above.

---

• Minutes between automatic backups:
  • Replace "OK" with a more useful string.
  • Update background color.
  • Change the text to title.
• Daily backups to keep:
  • Same as above.
• Weekly backups to keep:
  • Same as above.
• Monthly backups to keep:
  • Same as above.
• Network timeout:
  • Same as above, but there's no text to begin with.

Main screen

• Check database?:
  • Replace "OK" with a more useful string.
  • Update background color.
  • Change the title to "Check database".
  • Change the text to "This may take a longe time. Proceed?"
• Check media?:
  • Same as above.

---

• Empty cards:
  • Update background color.
• Import:
  • Same as above.
• Export:
  • Replace "OK" with a more useful string.
  • Update background color.
  • Add title "Export".

---

• Support AnkiDroid:
  • Update background color.
• Help:
  • Same as above.

Decks

• Create deck:

  • If you press the checkmark button on your keyboard, a toast appears inside the dialog!
  • Update background color.
  • Add "Name" to the border.

• Create subdeck:

  • Same as above.

• Create filtered deck:

  • If you press the checkmark button on your keyboard, a toast appears inside the dialog!
  • Update background color.
  • Add "Name" to the border.
  • Change the title to "Create filtered deck".

• Rename deck:

  • Same as above but with "New name" instead of "Name".

Custom study

• Custom study
  • Update background color.
• Increase today's new card limit:
  • Consider adding a title "Increase today's new card limit".
  • [Suggestion] Consider replacing the helper text with a toggle/checkbox to switch between increase/decrease. The button should change to match the state of the toggle.
  • Update background color.
• Increase today's review card limit:
  • Same as above but with "review" instead of "new".

---

• Review forgotten cards:
  • Replace "OK" with a more useful string.
  • Update background color.
  • Add a unit "day"/"days" to the box.
  • Consider changing the text to a title or adding one.
• Review ahead:
  • Same as above.
• Preview new cards:
  • Same as above.

---

• Study by card state or tag:
  • Update background color.
  • Add a title "Study by card state or tag".
  • Add a unit "card"/"cards" to the box.

Browser

• Select tags:
  • Update background color.
  • Update the title background color.
• Tags:
  • Same as above.
  • Replace "OK" with a more useful string. Maybe "Select" to match the "Select tags" dialog.
• Add tag:
  • Replace "OK" with a more useful string.
  • Update background color.

---

• Browser options:
  • Replace "OK" with a more useful string.
• Reset card progress:
  • Same as above.
• Find and replace:
  • Replace "OK" with a more useful string.
  • Update background color.
• Set due date:
  • Replace "OK" with a more useful string.
  • Consider adding text to the icons.
  • Consider replacing "Help" by a question icon in the upper right corner like the "Reset card progress" dialog.
• Reposition new cards:
  • Replace "OK" with a more useful string.
  • Update background color.
• Change note type:
  • Replace "OK" with a more useful string.
  • The tab text & icon should be colored blue to match the "Set due date" dialog.

Managing fields

• Add field:
  • Replace "OK" with a more useful string.
  • Update background color.
  • Add a border to the box and with "Name" in it.
• Rename field:
  • Update background color.
  • Add a border to the box and with "Name" in it.

---

• Delete field:
  • Replace "OK" with a more useful string.
  • Update background color.
• Reposition field:
  • Same as above.
  • Add a title "Reposition field".
  • Move "New position" into the border of the box. The range, e.g. "(1 ...2)" should be below the box in gray, similar to the "Set due date" dialog.

Note/card types

• Add note type:
  • Replace "OK" with a more useful string.
  • Update background color.
  • Add a title "Add note type".
  • Add a border to the box and move "Name" in it.
• Rename note type:
  • Update background color.
  • Add the text "Name" to the border.

---

• Add card type:
  • Replace "OK" with a more useful string.
  • Update background color.
  • Change the title to "Add card type".
  • [Suggestion] Consider adding a first dialog with a box like the others here for entering the name of the card type, before showing the confirmation dialog.
• Rename card type:
  • Update background color.
  • Remove the ":" from "New name:".
• Delete card type:
  • Replace "OK" with a more useful string.
  • Update background color.
  • Change the title to "Delete card type".
• Restore to Default:
  • Replace "OK" with a more useful string.
  • Update background color.
  • Change the title to sentence case.
• Browser appearance:
  • Not really a dialog, but the border titles "Question Format" and "Answer Format" should be lower case.
• Restore Default Values?:
  • This is the dialog that appears when you tap the "loop" icon in the "Browser appearance" screen.
  • Replace "OK" with a more useful string.
  • Update background color.
  • Add a title to "Restore default".
  • Change the text to "Are you sure you want to restore the browser appearance to default?".

Reminders

• Edit review reminder:
  • Replace "OK" with a more useful string.
  • Border text: "Card threshold".
  • Remove "Card threshold:" from the description and place the description above the entry box, making it wider.
  • Remove background color from the title.
  • Update background color.
  • Add "card"/"cards" unit in the box.
• Add review reminder:
  • Same as above.
• Select time:
  • Replace "OK" with a more useful string.
  • Change the "Select time" to a title.
  • In text mode: move the "Hour" and "Minute" into the borders.
• Delete this reminder?:
  • Replace "OK" with a more useful string.
  • Update background color.
  • Change the title to "Delete reminder".
  • Change the text to "This action cannot be undone. Are you sure?".

[smstone0]

@david-allison I'd be happy to take this as my first issue. Would you be able to assign it to me please?

[david-allison]

Sure @smstone0

[ZornHadNoChoice]

Let me add the filtered deck dialog to the list.

• It doesn't accept the name if it's a duplicate unless it's of the form Filtered Deck HH:MM, to which it appends a +.
• Anki Desktop allows duplicate names in the dialog but then adds a +.

I'm not sure which is better tbh.

[github-actions]

Hello 👋, this issue has been opened for more than 3 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

[david-allison]

Good First Issue:

Some use "Rename", others use "OK".

• List the affected dialogs on this issue.
  • We shouldn't be using OK if we can help it. The Material 2 Guidelines explain this:

  • Don’t use action text that fails to indicate what the selection will do. “Cancel” and “Delete” better indicate what will occur in this dialog.

• Replace 'OK' with a more useful string
  • See GeneratedTranslations, or the AnkiDroid strings
  • If we need to add a string, this is also acceptable, but only when we know there's no replacement