Skip to content

Comments

chore: convert HelpDialog to ViewBinding#20083

Merged
david-allison merged 1 commit intoankidroid:mainfrom
david-allison:vb-HelpDialog
Jan 15, 2026
Merged

chore: convert HelpDialog to ViewBinding#20083
david-allison merged 1 commit intoankidroid:mainfrom
david-allison:vb-HelpDialog

Conversation

@david-allison
Copy link
Member

Approach

How Has This Been Tested?

Brief test:

Pixel 9 Pro - Help is usable

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison mentioned this pull request Jan 12, 2026
92 tasks
@david-allison
Copy link
Member Author

Flaky test =>

Comment on lines 198 to 203
val contentRow =
requireActivity().layoutInflater.inflate(
R.layout.item_help_entry,
pageContentLayout,
binding.pageContent,
false,
) as TextView
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use binding for this as well:

val contentRow = ItemHelpEntryBinding.inflate(layoutInflater, binding.pageContent, false).root

@lukstbit lukstbit added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jan 14, 2026
Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lukstbit's comment is still good -> Needs Author Reply

@BrayanDSO BrayanDSO added Needs Author Reply Waiting for a reply from the original author Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jan 15, 2026
@david-allison
Copy link
Member Author

Thanks for holding off! I made the change, but the push failed

@david-allison
Copy link
Member Author

Force pushed and retested

@david-allison david-allison removed the Needs Author Reply Waiting for a reply from the original author label Jan 15, 2026
@david-allison david-allison added this pull request to the merge queue Jan 15, 2026
Merged via the queue into ankidroid:main with commit 387b2aa Jan 15, 2026
15 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jan 15, 2026
@github-actions github-actions bot added this to the 2.24 release milestone Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants