chore: convert HelpDialog to ViewBinding#20083
Merged
david-allison merged 1 commit intoankidroid:mainfrom Jan 15, 2026
Merged
Conversation
Member
Author
|
Flaky test => |
lukstbit
approved these changes
Jan 14, 2026
Comment on lines
198
to
203
| val contentRow = | ||
| requireActivity().layoutInflater.inflate( | ||
| R.layout.item_help_entry, | ||
| pageContentLayout, | ||
| binding.pageContent, | ||
| false, | ||
| ) as TextView |
Member
There was a problem hiding this comment.
Why not use binding for this as well:
val contentRow = ItemHelpEntryBinding.inflate(layoutInflater, binding.pageContent, false).rootIssue 11116
BrayanDSO
approved these changes
Jan 15, 2026
Member
Author
|
Thanks for holding off! I made the change, but the push failed |
e0b434b to
86d2063
Compare
Member
Author
|
Force pushed and retested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Approach
vbpdHow Has This Been Tested?
Brief test:
Pixel 9 Pro - Help is usable
Checklist