Skip to content

refactor(custom-study): use userInputValue #20074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikehardy merged 1 commit into from
Jan 12, 2026
Merged

refactor(custom-study): use userInputValue #20074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions AnkiDroid/src/main/java/com/ichi2/anki/dialogs/customstudy/CustomStudyDialog.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ import com.ichi2.anki.dialogs.tags.TagsDialogListener.Companion.ON_SELECTED_TAGS
import com.ichi2.anki.dialogs.tags.TagsDialogListener.Companion.ON_SELECTED_TAGS__SELECTED_TAGS
import com.ichi2.anki.launchCatchingTask
import com.ichi2.anki.libanki.DeckId
import com.ichi2.anki.libanki.Tags
import com.ichi2.anki.observability.undoableOp
import com.ichi2.anki.preferences.sharedPrefs
import com.ichi2.anki.snackbar.showSnackbar
Expand Down Expand Up @@ -374,7 +373,7 @@ class CustomStudyDialog : AnalyticsDialogFragment() {

// Get the value selected by user
val n =
binding.detailsEditText2.textAsIntOrNull() ?: run {
userInputValue ?: run {
Timber.w("Non-numeric user input was provided")
Timber.d("value: %s", binding.detailsEditText2.text.toString())
allowSubmit = true
Expand Down Expand Up @@ -423,8 +422,7 @@ class CustomStudyDialog : AnalyticsDialogFragment() {
}

binding.detailsEditText2.doAfterTextChanged {
val num = binding.detailsEditText2.textAsIntOrNull()
dialog.positiveButton.isEnabled = num != null && num != 0
dialog.positiveButton.isEnabled = userInputValue != null && userInputValue != 0
}

// Show soft keyboard
Expand Down