Skip to content

Comments

refactor(custom-study): use userInputValue#20074

Merged
mikehardy merged 1 commit intoankidroid:mainfrom
david-allison:vb-CustomStudyDialog
Jan 12, 2026
Merged

refactor(custom-study): use userInputValue#20074
mikehardy merged 1 commit intoankidroid:mainfrom
david-allison:vb-CustomStudyDialog

Conversation

@david-allison
Copy link
Member

@david-allison david-allison commented Jan 12, 2026

A refactoring I noticed while doing #11116

private val userInputValue: Int?
get() = binding.detailsEditText2.textAsIntOrNull()

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison added cleanup Non functional change that would improve the code readability Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jan 12, 2026
@david-allison david-allison mentioned this pull request Jan 12, 2026
92 tasks
@mikehardy mikehardy added this pull request to the merge queue Jan 12, 2026
Merged via the queue into ankidroid:main with commit 3f74831 Jan 12, 2026
19 checks passed
@david-allison david-allison deleted the vb-CustomStudyDialog branch January 12, 2026 15:28
@github-actions github-actions bot added this to the 2.24 release milestone Jan 12, 2026
@github-actions github-actions bot removed the Needs Second Approval Has one approval, one more approval to merge label Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Non functional change that would improve the code readability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants