fix: use standard res-auto namespace for app attributes by pankaj0695 · Pull Request #20022 · ankidroid/Anki-Android

pankaj0695 · 2026-01-05T13:21:54Z

Purpose / Description

Some preference XML files used a deprecated custom app namespace URI (http://arbitrary.app.namespace/com.ichi2.anki) instead of the standard http://schemas.android.com/apk/res-auto and/or a non-standard prefix (app1) for custom attributes.
This caused aapt to fail resolving custom attributes and resulted in build errors like attribute max not found.

Fixes

Fixes Deprecate usage of app1 in preferences #20018

Approach

Replaced the deprecated app namespace URI with the standard xmlns:app="http://schemas.android.com/apk/res-auto" in affected preference XML files.
Renamed the custom attribute prefix from app1 to app so the custom attributes resolve consistently via res-auto.

How Has This Been Tested?

Tested on Android Studio emulator: Medium Phone, API 29 (Android 10).
Verified the affected preference screens load correctly and the app builds without aapt attribute/namespace errors.

Checklist

Please, go through these checks before submitting the PR.

You have a descriptive commit message with a short title (first line, max 50 chars).
You have commented your code, particularly in hard-to-understand areas
You have performed a self-review of your own code
UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
UI Changes: You have tested your change using the Google Accessibility Scanner

BrayanDSO

Haven't tested, but the code looks good

david-allison

Doesn't work :/

AnkiDroid/src/main/res/xml/cram_deck_options.xml

BrayanDSO

Needs fixing in IncrementerNumberRangePreference as well

david-allison · 2026-01-05T15:42:47Z

AnkiDroid/src/main/java/com/ichi2/preferences/NumberRangePreference.kt

+        val resAuto = attrs.getAttributeIntValue("http://schemas.android.com/apk/res-auto", "min", Int.MIN_VALUE)
+        if (resAuto != Int.MIN_VALUE) return resAuto
+
+        return attrs.getAttributeIntValue(AnkiDroidApp.XML_CUSTOM_NAMESPACE, "min", 0)


Is there a reason AnkiDroidApp.XML_CUSTOM_NAMESPACE is still in use?

It’s still used for backwards compatibility with legacy android.preference.* preferences (NumberRangePreference, StepsPreference) that read custom attrs via getAttribute*Value(namespaceUri, ...). I’m reading res-auto first and keeping AnkiDroidApp.XML_CUSTOM_NAMESPACE as a fallback to avoid breaking any older XML.
Would you like me to remove the legacy namespace support from this and the StepsPreference code?

As far as I understand it, Brayan would like the entire namespace gone.

The details of custom XML namespaces in Android aren't something I'm familiar with, but I can't see a reason we'd want to keep it if the default app: namespace would work, and from a high-level perspective, removing the whole namespace is cleaner architecturally.

@BrayanDSO am I correct in my thinking here?

If it's only used at cram_deck_options, it can be ignored since #19669 will be merged soon.

About the rest, I couldn't have said it better myself.

pankaj0695 · 2026-01-05T16:34:44Z

I have made the requested changes and also tested it.

david-allison

app1 still exists:

Anki-Android/AnkiDroid/src/main/res/xml/preferences_advanced.xml

Line 25 in 16dfea9

xmlns:app1="http://schemas.android.com/apk/res-auto"

AnkiDroid/src/main/java/com/ichi2/anki/AnkiDroidApp.kt

AnkiDroid/src/main/java/com/ichi2/preferences/NumberRangePreferenceCompat.kt

pankaj0695 · 2026-01-05T19:15:27Z

Now I am using RES_AUTO_NAMESPACE everywhere and also change app1 to app and also checked for its occurrences in the code

david-allison

as-per comment

Please check the 'files changed' before submitting so we're reviewing a clean & final change

david-allison · 2026-01-05T19:19:54Z

AnkiDroid/src/main/res/values/attrs.xml

        <attr name="summaryFormat" format="string"/>
    </declare-styleable>

+    <declare-styleable name="NumberRangePreferenceCompat">


This appears to be unused. I would have expected a declare-styleable for each preference, rather than using the hardcoded namespace.

Why did you choose the namespace option?

Yes this is unused because I'm not reading min/max via R.styleable in preference, I used http://schemas.android.com/apk/res-auto as a shortcut.
Should I define a declare-styleable for each preference(NumberRangePreference, NumberRangePreferenceCompat & StepsPreference) and read attributes via R.styleable, instead of using the namespace approach?

I don't get why you chose the hardcoded namespace option. It's not something I'm too familiar with.

declare-styleable seems better intuitively, but I want to understand your reasoning.

Actually I did it this way because the preference was using XML_CUSTOM_NAMESPACE so I thought to use RES_AUTO_NAMESPACE the similar way. But now I will use declare-styleable which is better and update the code accordingly.

david-allison

cheers. Needs squashing

david-allison · 2026-01-06T21:39:20Z

AnkiDroid/src/main/res/values/attrs.xml

+        <attr name="min" />
+        <attr name="max"/>


inconsistent spacing

fix NumberRangePreference remove XML_CUSTOM_NAMESPACE used RES_AUTO_NAMESPACE everywhere its needed and change app1 to app Remove RES_AUTO_NAMESPACE and instead used declare-styleable fix spacing in attrs.xml

david-allison requested a review from BrayanDSO January 5, 2026 13:28

BrayanDSO approved these changes Jan 5, 2026

View reviewed changes

BrayanDSO added the Needs Second Approval Has one approval, one more approval to merge label Jan 5, 2026

david-allison requested changes Jan 5, 2026

View reviewed changes

AnkiDroid/src/main/res/xml/cram_deck_options.xml Show resolved Hide resolved

BrayanDSO requested changes Jan 5, 2026

View reviewed changes

david-allison reviewed Jan 5, 2026

View reviewed changes

david-allison added the Needs Author Reply Waiting for a reply from the original author label Jan 5, 2026

david-allison added Needs Review and removed Needs Author Reply Waiting for a reply from the original author Needs Second Approval Has one approval, one more approval to merge labels Jan 5, 2026

david-allison requested review from BrayanDSO and david-allison January 5, 2026 16:46

david-allison requested changes Jan 5, 2026

View reviewed changes

AnkiDroid/src/main/java/com/ichi2/anki/AnkiDroidApp.kt Outdated Show resolved Hide resolved

AnkiDroid/src/main/java/com/ichi2/preferences/NumberRangePreferenceCompat.kt Show resolved Hide resolved

david-allison requested changes Jan 5, 2026

View reviewed changes

david-allison reviewed Jan 5, 2026

View reviewed changes

david-allison added the Needs Author Reply Waiting for a reply from the original author label Jan 6, 2026

pankaj0695 requested a review from david-allison January 6, 2026 16:02

david-allison approved these changes Jan 6, 2026

View reviewed changes

fix: use standard res-auto namespace for app attributes

cbc8873

fix NumberRangePreference remove XML_CUSTOM_NAMESPACE used RES_AUTO_NAMESPACE everywhere its needed and change app1 to app Remove RES_AUTO_NAMESPACE and instead used declare-styleable fix spacing in attrs.xml

pankaj0695 force-pushed the fix-20018 branch from 9becd0a to cbc8873 Compare January 7, 2026 07:04

BrayanDSO approved these changes Jan 7, 2026

View reviewed changes

BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Author Reply Waiting for a reply from the original author Needs Review labels Jan 7, 2026

BrayanDSO added this pull request to the merge queue Jan 7, 2026

Merged via the queue into ankidroid:main with commit f157e17 Jan 7, 2026
15 checks passed

github-actions bot added this to the 2.24 release milestone Jan 7, 2026

github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jan 7, 2026

Uh oh!

Comments

Conversation

pankaj0695 commented Jan 5, 2026

Purpose / Description

Fixes

Approach

How Has This Been Tested?

Checklist

Uh oh!

BrayanDSO left a comment

Choose a reason for hiding this comment

Uh oh!

david-allison left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BrayanDSO left a comment

Choose a reason for hiding this comment

Uh oh!

david-allison Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

pankaj0695 Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

david-allison Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BrayanDSO Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

pankaj0695 commented Jan 5, 2026

Uh oh!

david-allison left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pankaj0695 commented Jan 5, 2026

Uh oh!

david-allison left a comment

Choose a reason for hiding this comment

Uh oh!

david-allison Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pankaj0695 Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

david-allison Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

pankaj0695 Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

david-allison left a comment

Choose a reason for hiding this comment

Uh oh!

david-allison Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

david-allison Jan 5, 2026 •

edited

Loading

david-allison Jan 5, 2026 •

edited

Loading