feat: move fixed port setting to Advanced

so regular users can use it

Author: BrayanDSO

AnkiDroid/src/main/java/com/ichi2/anki/analytics/UsageAnalytics.kt

@@ -584,6 +584,7 @@ object UsageAnalytics {
             R.string.type_in_answer_focus_key, // Focus ‘type in answer’
             R.string.media_import_allow_all_files_key, // Allow all files in media imports
             R.string.enable_api_key, // Enable AnkiDroid API
+            R.string.use_fixed_port_pref_key, // localStorage in Study Screen
             // ******************************** App bar buttons ****************************************
             R.string.reset_custom_buttons_key,
             R.string.custom_button_undo_key,

AnkiDroid/src/main/java/com/ichi2/anki/settings/Prefs.kt

@@ -188,6 +188,12 @@ object Prefs {
     val answerButtonsSize: Int
         get() = getInt(R.string.answer_button_size_preference, 100)
 
+    // **************************************** Advanced **************************************** //
+
+    var useFixedPortInReviewer by booleanPref(R.string.use_fixed_port_pref_key, false)
+
+    var reviewerPort by intPref(R.string.reviewer_port_pref_key, defaultValue = 0)
+
     // ************************************* Developer options ********************************** //
 
     /**
@@ -198,8 +204,4 @@ object Prefs {
     var isDevOptionsEnabled: Boolean
         get() = getBoolean(R.string.dev_options_enabled_by_user_key, false) || BuildConfig.DEBUG
         set(value) = putBoolean(R.string.dev_options_enabled_by_user_key, value)
-
-    var useFixedPortInReviewer by booleanPref(R.string.use_fixed_port_pref_key, false)
-
-    var reviewerPort by intPref(R.string.reviewer_port_pref_key, defaultValue = 0)
 }

AnkiDroid/src/main/res/values/10-preferences.xml

@@ -293,6 +293,9 @@ this formatter is used if the bind only applies to the answer">A: %s</string>
     <string name="pref_cat_experimental" maxLength="41" tools:ignore="UnusedResources">Experimental</string>
     <string name="readtext_deprecation_warn">AnkiDroid has introduced a better TTS mechanism which is compatible with other Anki clients and includes more voices and improvements to language playback!\n\nPlease upgrade as soon as possible, as this setting will be removed soon</string>
     <string name="readtext_reviewer_warn" tools:ignore="UnusedResources">Please upgrade to the new text to speech format</string>
+    <string name="pref_fixed_port_title" maxLength="41">localStorage in Study Screen</string>
+    <string name="pref_fixed_port_summary"
+        >Enables JavaScript localStorage by using a fixed server port in the Study Screen</string>
 
     <!-- Developer options -->
     <string name="pref_cat_dev_options" maxLength="41">Developer options</string>

AnkiDroid/src/main/res/xml/preferences_advanced.xml

@@ -88,6 +88,11 @@
                 android:key="@string/media_import_allow_all_files_key"
                 android:summary="@string/media_import_allow_all_files_summ"
                 android:title="@string/media_import_allow_all_files" />
+            <SwitchPreferenceCompat
+                android:title="@string/pref_fixed_port_title"
+                android:key="@string/use_fixed_port_pref_key"
+                android:summary="@string/pref_fixed_port_summary"
+                android:defaultValue="false"/>
         </PreferenceCategory>
         <PreferenceCategory
             android:key="@string/pref_cat_plugins_key"

AnkiDroid/src/main/res/xml/preferences_dev_options.xml

@@ -48,10 +48,6 @@
         android:title="Set Database to pre-Scoped Storage default"
         android:summary="Touch here to set the database path to /storage/emulated/0/AnkiDroid"
         android:key="@string/pref_set_database_path_debug_key"/>
-    <SwitchPreferenceCompat
-        android:title="Use fixed port in the Reviewer"
-        android:key="@string/use_fixed_port_pref_key"
-        android:defaultValue="false"/>
     <SwitchPreferenceCompat
         android:title="New congrats screen"
         android:key="@string/new_congrats_screen_pref_key"