Skip to content

chore: convert StudyOptionsActivity to ViewBinding #19428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-allison merged 2 commits into from
Nov 6, 2025
Merged

chore: convert StudyOptionsActivity to ViewBinding #19428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2dfdd3
chore: convert StudyOptionsActivity to ViewBinding
david-allison Sep 10, 2025
e1a3c02
docs: StudyOptions
david-allison Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions AnkiDroid/src/main/java/com/ichi2/anki/StudyOptionsActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,11 @@ import com.ichi2.widget.WidgetStatus
import kotlinx.coroutines.launch
import timber.log.Timber

/**
* Hosts [StudyOptionsFragment] when non-fragmented
*/
class StudyOptionsActivity :
AnkiActivity(),
AnkiActivity(R.layout.studyoptions),
ChangeManager.Subscriber {
private var undoState = UndoState()

Expand All @@ -45,7 +48,6 @@ class StudyOptionsActivity :
return
}
super.onCreate(savedInstanceState)
setContentView(R.layout.studyoptions)
enableToolbar().apply { title = "" }
if (savedInstanceState == null) {
loadStudyOptionsFragment()
Expand Down
9 changes: 9 additions & 0 deletions AnkiDroid/src/main/java/com/ichi2/anki/StudyOptionsFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,15 @@ import kotlinx.coroutines.launch
import org.intellij.lang.annotations.Language
import timber.log.Timber

/**
* Displays an overview of a deck (title, counts, description) and allows studying or modification
* of the deck (Unbury, Deck Options, Custom Study)
*
* Filtered decks may be emptied or rebuilt
*
* On a tablet, this is the primary screen to study a deck and appears inside [DeckPicker]
* On a phone, this is hosted inside [StudyOptionsActivity], opened via the the [DeckPicker] counts
*/
class StudyOptionsFragment :
Fragment(),
ChangeManager.Subscriber,
Expand Down