Skip to content

Comments

chore: convert StudyOptionsActivity to ViewBinding#19428

Merged
david-allison merged 2 commits intoankidroid:mainfrom
david-allison:StudyOptionsActivity-to-ViewBinding
Nov 6, 2025
Merged

chore: convert StudyOptionsActivity to ViewBinding#19428
david-allison merged 2 commits intoankidroid:mainfrom
david-allison:StudyOptionsActivity-to-ViewBinding

Conversation

@david-allison
Copy link
Member

Approach


Commit 2: documented the classes a little beter

How Has This Been Tested?

Brief test using

  • Pixel 6 Pro API 33 Emulator - screen opens

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Nov 6, 2025
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Small question related to the binding use, merge at will.

@lukstbit lukstbit added Needs Author Reply Waiting for a reply from the original author Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Nov 6, 2025
@david-allison david-allison force-pushed the StudyOptionsActivity-to-ViewBinding branch from 02ddd0b to e1a3c02 Compare November 6, 2025 14:30
@david-allison david-allison removed the Needs Author Reply Waiting for a reply from the original author label Nov 6, 2025
@david-allison david-allison added this pull request to the merge queue Nov 6, 2025
Merged via the queue into ankidroid:main with commit f5626be Nov 6, 2025
15 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Nov 6, 2025
@github-actions github-actions bot added this to the 2.23 release milestone Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants