Hide unrelated note editor content for image occlusion notetypes#19271
Merged
david-allison merged 2 commits intoankidroid:mainfrom Oct 17, 2025
Merged
Hide unrelated note editor content for image occlusion notetypes#19271david-allison merged 2 commits intoankidroid:mainfrom
david-allison merged 2 commits intoankidroid:mainfrom
Conversation
5 tasks
BrayanDSO
reviewed
Oct 9, 2025
Member
BrayanDSO
left a comment
BrayanDSO
left a comment
There was a problem hiding this comment.
While testing, I wasn't able to edit those fields on the desktop version.
IIRC, that was possible in the past. Otherwise, doesn't make much sense to keep them there.
Some people, including myself, want to add comments in the back field of their notes.
BrayanDSO
added
the
Needs Author Reply
Showing the fields is not needed because we handle the image occlusion with a backend page, desktop app also doesn't show the fields for image occlusion and it's confusing for the users.
The backend page handles the tags for occlusion notetypes.
lukstbit
force-pushed
the
feat_hideFieldsForImageOcclusion
branch
from
32bec8a to
672a62e
Compare
Member
Author
|
I removed the mentioned code section. I'm not sure if this was the target of the 'Needs author reply'. The fields we present to the user for image occlusion types are useless. |
BrayanDSO
removed
the
Needs Author Reply
BrayanDSO
approved these changes
Oct 12, 2025
BrayanDSO
added
Needs Second Approval
david-allison
approved these changes
Oct 17, 2025
github-actions
bot
removed
the
Needs Second Approval
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Hides the fields and tags button in NoteEditorFragment when the notetype is set to image occlusion. The desktop app doesn't show the fields for this type of notetype and the backend page handles the tags.
Before/after for image occlusion:
Fixes
How Has This Been Tested?
Ran the tests, checked the behavior.
Checklist