Skip to content

Comments

Fix Keyboard Shortcuts Behavior in Deck Picker (Fragmented)#17831

Merged
BrayanDSO merged 1 commit intoankidroid:mainfrom
sanjaysargam:short-cut
Jan 16, 2025
Merged

Fix Keyboard Shortcuts Behavior in Deck Picker (Fragmented)#17831
BrayanDSO merged 1 commit intoankidroid:mainfrom
sanjaysargam:short-cut

Conversation

@sanjaysargam
Copy link
Member

Purpose / Description

Non-functional keyboard shortcuts were removed from the list in the deck picker when the screen is not fragmented.

Fixes

Approach

Modified the shortcuts list to conditionally include the "DEL", "Shift+DEL", and "R" shortcuts based on the fragmented flag. These shortcuts are only included if fragmented is true, while others remain unchanged.

How Has This Been Tested?

Chromebook

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison added the Needs Second Approval Has one approval, one more approval to merge label Jan 16, 2025
Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@BrayanDSO BrayanDSO added this pull request to the merge queue Jan 16, 2025
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jan 16, 2025
Merged via the queue into ankidroid:main with commit 23b4783 Jan 16, 2025
12 checks passed
@github-actions github-actions bot added this to the 2.21 release milestone Jan 16, 2025
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jan 16, 2025
@david-allison
Copy link
Member

Hi there @sanjaysargam! This is the OpenCollective Notice for PRs merged from 2025-01-01 through 2025-01-31

Starting 2025, we have updated our selection process for Open Collective, and you are eligible for compensation for your work, the process with details is here:

https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

This note applies to all PRs merged for this month.

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keyboard shortcuts issues in the deck picker [fragmented]

4 participants