Allow override eventProperties #55
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For my particular case I need to pull off the element more properties than pulled by default (`id`, `className`, `section`). To be more precise, I want to pull whole `dataset`. The most straightforward way to do so is overriding `eventProperties`, which is used in `trackClicks`, `trackSubmits` and `trackChanges`. However in its current state I can override `trackClick` and others, but that would be too much of a monkey patch. I believe making `eventProperties` overridable won't hurt anyone and will improve the options to customize events data.
|
@ankane ? |
|
Hey @dmitriy-kiriyenko, thanks for the PR, and sorry for the delay (have been focused on other projects). This makes sense to me. Let's add it as a config option instead of a separate method. ahoy.configure({
eventProperties: function(e) { ... }
}) |
This was referenced Oct 6, 2020
|
@ankane if I finish this one off, would you be willing to merge this in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For my particular case I need to pull off the element more properties than pulled by default (
id,className,section). To be more precise, I want to pull wholedataset.The most straightforward way to do so is overriding
eventProperties, which is used intrackClicks,trackSubmitsandtrackChanges.However in its current state I can override
trackClickand others, but that would be too much of a monkey patch.I believe making
eventPropertiesoverridable won't hurt anyone and will improve the options to customize events data.