-
Notifications
You must be signed in to change notification settings - Fork 119
Track clicks when element inside of <a href> tag is clicked. #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey @fleitz, thanks for the PR, and sorry for the delay (have been focused on other projects). This change makes sense to me. Instead of setting |
|
Yeah, that sounds like a way cleaner way to implement. |
|
@ankane implemented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fleitz, looking better. Added a few comments inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fleitz, added a few more comments. Please follow the existing spacing everywhere.
| return obj; | ||
| } | ||
|
|
||
| function eventProperties(e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No change needed on this line.
|
Thanks @fleitz! This is a great feature. |
<a href="#foo"> <div> <img src="clickable_image"> </div> </a>Expected result: Clicking on image results in tracking
Actual Result:
Clicking on image does not result in tracking.