This repository was archived by the owner on Jul 29, 2024. It is now read-only.
chore(test): move ng2/timeout_spec off of the control flow #5027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reference #4995 |
|
Interesting. I'm not sure about this either. We can address this later. I plan to leave this as is commented out until we get more direction on this. |
37 tasks
|
Okay I looked into this a bit more, the failure is there probably because of this controlFlow call. https://github.com/angular/protractor/blob/master/lib/browser.ts#L660 Probably the error is not properly thrown because we are do not execute the controlFlow(). We will come back to this when we untangle Protractor and the control flow. |
|
@CrispusDH Could you rebase this? I fixed the control flow issue in the browser. Thank you! |
|
@cnishina , unfortunately the error is still the same as was |
|
Closing this one. It looks like we got it done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure should I or not change expected error message (test is failed with the same result on CircleCI and locally)?
Expected error message:
Timed out waiting for asynchronous Angular tasks to finishCurrent error message:
Failed: script timeout: result was not received in 11 seconds@cnishina , could you take a look at this PR, please