Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

selenium 4 upgrade: move test suite off of the control flow  #5017

@cnishina

Description

@cnishina

move test suite off of the control flow

test suite should pass here

complete by: 11/09

cnishina work:

  • basic/element_spec.js
  • basic/lib_spec.js
  • basic/locators_spec.js
  • basic/mockmodule_spec.js
  • altRoot/*_spec.js and inferRoot/*_spec.js
  • mocha/*_spec.js
  • onCleanUp/*_spec.js
  • onPrepare/*_spec.js
  • suites/*_spec.js
  • withLogin/*_spec.js
  • plugins/*_spec.js
  • interaction
  • restartBrowserBetweenTestConf
  • directConnect, getCapabilities
  • driverProviderUseExistingWebDriver <-- I think this needs to be removed
  • controlLock
  • noCF built tests
  • error tests
  • driverProviderLocal
  • driverProviderAttachSession
  • failure tests
  • turn on tests in suite not turned on (probably due to merging).
  • final review: ci test suite (travis) and basicConf.js should use all the spec files. Not just the subset we used for testing.

Misc:

@CrispusDH, this means in the basic, I will not touch these files if you want to take a shot at them. Please work on one file at a time as a pull request.

  • basic/expected_conditions_spec.js
  • basic/handling_spec.js
  • basic/navigation_spec.js
  • basic/polling_spec.js
  • basic/restart_spec.js
  • basic/synchronize_spec.js
  • angular2 (we'll have to look into this one). Note in Misc (above)
  • customFramework
  • noGlobals
  • hybrid
  • interactive_tests <-- Need to turn on <-- update: deleted

Also a quick review of the PR submitted #4998, it looks like you have a lot of trailing spaces on lines. If you are using visual studio code, there is a setting to remove trailing settings. (https://stackoverflow.com/questions/30884131/remove-trailing-spaces-automatically-or-with-a-shortcut)

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions