Skip to content

fix(cdk/tree): avoid breaking change in constructor #29648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2024
Merged

fix(cdk/tree): avoid breaking change in constructor #29648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/cdk/tree/tree.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,8 @@ export class CdkTree<T, K = T>
OnDestroy,
OnInit
{
private _dir = inject(Directionality);

/** Subject that emits when the component has been destroyed. */
private readonly _onDestroy = new Subject<void>();

Expand Down Expand Up @@ -265,7 +267,6 @@ export class CdkTree<T, K = T>
constructor(
private _differs: IterableDiffers,
private _changeDetectorRef: ChangeDetectorRef,
private _dir: Directionality,
) {}

ngAfterContentInit() {
Expand Down
2 changes: 1 addition & 1 deletion tools/public_api_guard/cdk/tree.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export class CdkNestedTreeNode<T, K = T> extends CdkTreeNode<T, K> implements Af

// @public
export class CdkTree<T, K = T> implements AfterContentChecked, AfterContentInit, AfterViewInit, CollectionViewer, OnDestroy, OnInit {
constructor(_differs: IterableDiffers, _changeDetectorRef: ChangeDetectorRef, _dir: Directionality);
constructor(_differs: IterableDiffers, _changeDetectorRef: ChangeDetectorRef);
childrenAccessor?: (dataNode: T) => T[] | Observable<T[]>;
collapse(dataNode: T): void;
collapseAll(): void;
Expand Down