fix(cdk/tree): avoid breaking change in constructor #29648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In angular#29062 a new parameter was added to the `CdkTree` constructor which is a breaking change. These changes switch to using `inject` which allows us to avoid the breaking change. Fixes angular#29595.
crisbeto
requested review from
amysorto and
andrewseguin
and removed request for
a team
andrewseguin
approved these changes
Aug 27, 2024
crisbeto
added a commit
that referenced
this pull request
Aug 27, 2024
This was referenced Sep 19, 2024
This was referenced Sep 24, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #29062 a new parameter was added to the
CdkTreeconstructor which is a breaking change.These changes switch to using
injectwhich allows us to avoid the breaking change.Fixes #29595.