Skip to content

fix(material/stepper): isErrorState accepts AbstractControl instead of UntypedFormControl to avoid compiler errors when strict typing is enabled #25105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2022
Merged

fix(material/stepper): isErrorState accepts AbstractControl instead of UntypedFormControl to avoid compiler errors when strict typing is enabled #25105

merged 1 commit into from
Jun 23, 2022

Conversation

@amysorto
Copy link
Contributor

@amysorto amysorto commented Jun 17, 2022

Fixes #25103

@amysorto amysorto added the target: patch This PR is targeted for the next patch release label Jun 17, 2022
@amysorto amysorto requested review from crisbeto and jelbourn June 17, 2022 21:41
crisbeto
crisbeto approved these changes Jun 18, 2022
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion removed their request for review June 20, 2022 19:37
@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Jun 21, 2022
@amysorto
fix(material/stepper): isErrorState accepts AbstractControl instead o…
da3decf 
…f UntypedFormControl to avoid compiler errors when strict typing is enabled
@amysorto amysorto merged commit 79fc046 into angular:main Jun 23, 2022
amysorto added a commit that referenced this pull request Jun 23, 2022
@amysorto
fix(material/stepper): isErrorState accepts AbstractControl instead o…
c970ff9 
…f UntypedFormControl to avoid compiler errors when strict typing is enabled (#25105)

(cherry picked from commit 79fc046)
amysorto added a commit that referenced this pull request Jun 23, 2022
@amysorto
fix(material/stepper): isErrorState accepts AbstractControl instead o…
b95b0ad 
…f UntypedFormControl to avoid compiler errors when strict typing is enabled (#25105)

(cherry picked from commit 79fc046)
This was referenced Jul 1, 2022
Closed
Closed
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Jul 4, 2022
Update angularmaterial monorepo to v14.0.4 (#1441)
534ea08 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`14.0.3` -> `14.0.4`](https://renovatebot.com/diffs/npm/@angular%2fcdk/14.0.3/14.0.4) |
| [@angular/material](https://github.com/angular/components) | dependencies | patch | [`14.0.3` -> `14.0.4`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/14.0.3/14.0.4) |

---

### Release Notes

<details>
<summary>angular/components</summary>

### [`v14.0.4`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1404-sapphire-sandal-2022-06-29)

[Compare Source](angular/components@14.0.3...14.0.4)

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [c970ff9d3](angular/components@c970ff9) | fix | **stepper:** isErrorState accepts AbstractControl instead of UntypedFormControl to avoid compiler errors when strict typing is enabled ([#&#8203;25105](angular/components#25105)) |

##### material-experimental

| Commit | Type | Description |
| -- | -- | -- |
| [1b50a0743](angular/components@1b50a07) | fix | **mdc-chips:** missing role for trailing actions container ([#&#8203;25160](angular/components#25160)) |

##### docs

| Commit | Type | Description |
| -- | -- | -- |
| [c4ae88fb5](angular/components@c4ae88f) | fix | rename master to something else ([#&#8203;25151](angular/components#25151)) |

##### multiple

| Commit | Type | Description |
| -- | -- | -- |
| [301f6b0ef](angular/components@301f6b0) | fix | touch targets not excluded in densities lower than -2 ([#&#8203;25108](angular/components#25108)) |

#### Special Thanks

Ammar Najjar, Amy Sorto, Angular Robot, James Jansson, Kristiyan Kostadinov, Paul Gschwendtner, Zach Arend and renovate\[bot]

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1441
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@sync-by-unito sync-by-unito bot mentioned this pull request Jul 19, 2022
Closed
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jul 24, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba mmalerba approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(MatStep): MatStep.isErrorState should accept AbstractControl instead of UntypedFormControl

4 participants

@amysorto @crisbeto @mmalerba @jelbourn