bug(MatStep): MatStep.isErrorState should accept AbstractControl instead of UntypedFormControl

[migmigmig]

Is this a regression?

• Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

I'm going through the process of activating strict template typechecking.

Our legacy code sends FormControlGroup instances into isErrorState. Unfortunately, the compiler won't accept a FormControlGroup instance for an UntypedFormControl.

However, the underlying ErrorStateMatcher accepts AbstractControl. And everything has seemed fine (for years) with passing a group here.

As a secondary item, it would be great if methods that take " | null " as part of their parameter types would also allow those params to be optional?

Thanks!

Reproduction

Steps to reproduce:

1. Pass a FormControlGroup instance as the first param to MatStep.isErrorState()

Expected Behavior

Compiler happily accepts FormControlGroup.

Actual Behavior

Compiler complains that FormControlGroup doesn't match UntypedFormControl.

Environment

• Angular:
• CDK/Material:
• Browser(s):
• Operating System (e.g. Windows, macOS, Ubuntu):

[jelbourn]

@amysorto could you take a look at this? It should be a pretty quick fix

[crisbeto]

Worth noting that we're also using UntypedFormControl in mixinErrorState which should be changed.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}