Skip to content

build: replace dynamic require with import statement for ESM #25064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 11, 2022
Merged

build: replace dynamic require with import statement for ESM #25064

merged 2 commits into from
Jun 11, 2022

Conversation

devversion
Copy link
Member

Follow-up to: #25062.

@devversion devversion requested a review from crisbeto June 11, 2022 14:27
@devversion devversion requested a review from a team as a code owner June 11, 2022 14:27
@devversion devversion added action: merge The PR is ready for merge by the caretaker merge safe merge: preserve commits When the PR is merged, a rebase and merge should be performed target: patch This PR is targeted for the next patch release labels Jun 11, 2022
@devversion devversion merged commit c990d91 into angular:main Jun 11, 2022
@devversion devversion deleted the fix-slack-notifications-missing-ts-node branch June 11, 2022 14:55
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker merge: preserve commits When the PR is merged, a rebase and merge should be performed target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devversion @crisbeto