ci: fix slack notification script failing due to missing ts-node
#25062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TS node is no longer automatically registering in the `ng-dev` tool, so the config cannot be loaded anymore. Callers of `getConfig()` are required to manually wire up TS-Node, mostly now because ESM ts-node **cannot** be registered at runtime anymore. So, the fix here is to either run the slack notify script with `node --loader ts-node/esm` or just run it using `ts-node` directly, while writing it in TS. The latter one seems the most reasonable.
crisbeto
approved these changes
Jun 11, 2022
devversion
added
action: merge
devversion
added a commit
that referenced
this pull request
Jun 11, 2022
…25062) TS node is no longer automatically registering in the `ng-dev` tool, so the config cannot be loaded anymore. Callers of `getConfig()` are required to manually wire up TS-Node, mostly now because ESM ts-node **cannot** be registered at runtime anymore. So, the fix here is to either run the slack notify script with `node --loader ts-node/esm` or just run it using `ts-node` directly, while writing it in TS. The latter one seems the most reasonable. (cherry picked from commit 7f5bff7)
devversion
added a commit
to devversion/material2
that referenced
this pull request
Jun 11, 2022
devversion
added a commit
to devversion/material2
that referenced
this pull request
Jun 11, 2022
devversion
added a commit
that referenced
this pull request
Jun 11, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TS node is no longer automatically registering in the
ng-devtool, sothe config cannot be loaded anymore. Callers of
getConfig()arerequired to manually wire up TS-Node, mostly now because ESM ts-node
cannot be registered at runtime anymore. So, the fix here is to
either run the slack notify script with
node --loader ts-node/esmorjust run it using
ts-nodedirectly, while writing it in TS.The latter one seems the most reasonable.