build: ensure project version is set correctly in NPM package output #19841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In framework, the version placeholder computation was incorrect in some situations. i.e. the release packages used a version that indicates local changes like `x.x.x-local-changes`. We should ensure that the release output matches the expected version. This is especially becoming relevant when we switch to a shared Bazel workspace status command from the dev-infra package. The workspace status command is responsible for determining the version placeholder value when building with `--config=release`.
googlebot
added
the
cla: yes
devversion
added
merge safe
target: patch
josephperrott
added
lgtm
action: merge
mmalerba
pushed a commit
that referenced
this pull request
Jul 8, 2020
…19841) In framework, the version placeholder computation was incorrect in some situations. i.e. the release packages used a version that indicates local changes like `x.x.x-local-changes`. We should ensure that the release output matches the expected version. This is especially becoming relevant when we switch to a shared Bazel workspace status command from the dev-infra package. The workspace status command is responsible for determining the version placeholder value when building with `--config=release`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In framework, the version placeholder computation was incorrect
in some situations. i.e. the release packages used a version that
indicates local changes like
x.x.x-local-changes. We should ensurethat the release output matches the expected version.
This is especially becoming relevant when we switch to a shared
Bazel workspace status command from the dev-infra package. The
workspace status command is responsible for determining the version
placeholder value when building with
--config=release.