build: ensure project version is set correctly in NPM package output (#19841)

In framework, the version placeholder computation was incorrect
in some situations. i.e. the release packages used a version that
indicates local changes like `x.x.x-local-changes`. We should ensure
that the release output matches the expected version.

This is especially becoming relevant when we switch to a shared
Bazel workspace status command from the dev-infra package. The
workspace status command is responsible for determining the version
placeholder value when building with `--config=release`.

Author: devversion

tools/release/release-output/check-package.ts

@@ -6,10 +6,10 @@ import {Version} from '../version-name/parse-version';
 
 import {
   checkCdkPackage,
-  checkMaterialPackage,
-  checkPackageJsonFile,
-  checkPackageJsonMigrations,
+  checkEntryPointPackageJsonFile,
   checkJavaScriptOutput,
+  checkMaterialPackage,
+  checkPrimaryPackageJson,
   checkTypeDefinitionFile
 } from './output-validations';
 
@@ -64,7 +64,7 @@ export function checkReleasePackage(
   // Check each "package.json" file in the release output. We want to ensure
   // that there are no invalid file references in the entry-point definitions.
   packageJsonFiles.forEach(filePath => {
-    checkPackageJsonFile(filePath).forEach(message => addFailure(message, filePath));
+    checkEntryPointPackageJsonFile(filePath).forEach(message => addFailure(message, filePath));
   });
 
   // Special release validation checks for the "material" release package.
@@ -82,7 +82,7 @@ export function checkReleasePackage(
     addFailure('No "README.md" file found in package output.');
   }
 
-  checkPackageJsonMigrations(join(packagePath, 'package.json'), currentVersion)
+  checkPrimaryPackageJson(join(packagePath, 'package.json'), currentVersion)
       .forEach(f => addFailure(f));
 
   // In case there are failures for this package, we want to print those

tools/release/release-output/output-validations.ts

@@ -18,8 +18,7 @@ const bazelManifestPath = /(angular_material|external)\//;
  * List of fields which are mandatory in entry-point "package.json" files and refer
  * to files in the release output.
  */
-const packageJsonPathFields =
-    ['main', 'module', 'typings', 'es2015', 'fesm2015', 'esm2015'];
+const packageJsonPathFields = ['main', 'module', 'typings', 'es2015', 'fesm2015', 'esm2015'];
 
 /**
  * Checks the specified JavaScript file and ensures that it does not
@@ -45,11 +44,11 @@ export function checkJavaScriptOutput(filePath: string): string[] {
 }
 
 /**
- * Checks a "package.json" file by ensuring that common fields which are
+ * Checks an entry-point "package.json" file by ensuring that common fields which are
  * specified in the Angular package format are present. Those fields which
  * resolve to paths are checked so that they do not refer to non-existent files.
  */
-export function checkPackageJsonFile(filePath: string): string[] {
+export function checkEntryPointPackageJsonFile(filePath: string): string[] {
   const fileContent = readFileSync(filePath, 'utf8');
   const parsed = JSON.parse(fileContent);
   const packageJsonDir = dirname(filePath);
@@ -111,6 +110,31 @@ export function checkTypeDefinitionFile(filePath: string): string[] {
   return failures;
 }
 
+/**
+ * Checks the primary `package.json` file of a release package. Currently we ensure
+ * that the version and migrations are set up correctly.
+ */
+export function checkPrimaryPackageJson(
+    packageJsonPath: string, currentVersion: Version): string[] {
+  const expectedVersion = currentVersion.format();
+  const packageJson = JSON.parse(readFileSync(packageJsonPath, 'utf8'));
+  const failures: string[] = [];
+
+  if (!packageJson.version) {
+    failures.push(`No version set. Expected: ${expectedVersion}`);
+  } else if (packageJson.version !== expectedVersion) {
+    failures.push(
+        `Unexpected package version. Expected: ${expectedVersion} but got: ${packageJson.version}`);
+  }
+
+  if (packageJson['ng-update'] && packageJson['ng-update'].migrations) {
+    failures.push(...checkMigrationCollection(
+        packageJson['ng-update'].migrations, dirname(packageJsonPath), currentVersion));
+  }
+
+  return failures;
+}
+
 /**
  * Checks the ng-update migration setup for the specified "package.json"
  * file if present.