build: add job that ensures view engine AOT compatibility #19531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
This is blocked on #19516. Once this PR lands, we could merge this. |
devversion
added
blocked
Surprisingly with the switch to Ivy, we lost our infrastructure that ensures View Engine AOT compatibility. View Engine compiler is sometimes slighlty stricter in AOT as its pre-compiled factories are in external classes. This requires variables to be "public" when they are referenced in a template. In Ivy, these properties could actually be `protected` or `private` too. We already run tests against View Engine, but not in AOT. This is because View Engine compiler does not process un-exported test classes. In the future, with Ivy-only, we can run tests in AOT mode.
devversion
added
action: merge
devversion
force-pushed
the
build/add-job-to-ensure-view-engine-aot-compat
branch
from
78b39f4 to
379e0a6
Compare
|
Rebased. This is now ready to land so that we don't regress with View Engine AOT compatibility. |
devversion
added
the
P2
andrewseguin
pushed a commit
that referenced
this pull request
Jun 9, 2020
Surprisingly with the switch to Ivy, we lost our infrastructure that ensures View Engine AOT compatibility. View Engine compiler is sometimes slighlty stricter in AOT as its pre-compiled factories are in external classes. This requires variables to be "public" when they are referenced in a template. In Ivy, these properties could actually be `protected` or `private` too. We already run tests against View Engine, but not in AOT. This is because View Engine compiler does not process un-exported test classes. In the future, with Ivy-only, we can run tests in AOT mode.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surprisingly with the switch to Ivy, we lost our infrastructure
that ensures View Engine AOT compatibility. View Engine compiler
is sometimes slighlty stricter in AOT as its pre-compiled factories
are in external classes. This requires variables to be "public" when
they are referenced in a template. In Ivy, these properties could
actually be
protectedorprivatetoo.We already run tests against View Engine, but not in AOT. This is
because View Engine compiler does not process un-exported test classes.
In the future, with Ivy-only, we can run tests in AOT mode.