Skip to content

Commit 379e0a6

Browse files
committed
build: add job that ensures view engine AOT compatibility
Surprisingly with the switch to Ivy, we lost our infrastructure that ensures View Engine AOT compatibility. View Engine compiler is sometimes slighlty stricter in AOT as its pre-compiled factories are in external classes. This requires variables to be "public" when they are referenced in a template. In Ivy, these properties could actually be `protected` or `private` too. We already run tests against View Engine, but not in AOT. This is because View Engine compiler does not process un-exported test classes. In the future, with Ivy-only, we can run tests in AOT mode.
1 parent c05a07e commit 379e0a6

File tree

1 file changed

+23
-0
lines changed

1 file changed

+23
-0
lines changed

.circleci/config.yml

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,27 @@ jobs:
169169
# the "build_release_packages" and "publish_snapshots" jobs.
170170
- run: bazel build src/... --build_tag_filters=-docs-package,-release-package
171171

172+
# -----------------------------------
173+
# Job which ensures that all non-test Bazel targets build properly
174+
# in View Engine configuration.
175+
# -----------------------------------
176+
view_engine_build:
177+
<<: *job_defaults
178+
resource_class: xlarge
179+
environment:
180+
GCP_DECRYPT_TOKEN: *gcp_decrypt_token
181+
steps:
182+
- *checkout_code
183+
- *restore_cache
184+
- *setup_bazel_ci_config
185+
- *setup_bazel_remote_execution
186+
- *yarn_install
187+
- *setup_bazel_binary
188+
189+
# Exclude release and docs packages here as those will be built within
190+
# the "build_release_packages" and "publish_snapshots" jobs.
191+
- run: bazel build src/... --build_tag_filters=-docs-package,-release-package --config=view-engine
192+
172193
# --------------------------------------------------------------------------------------------
173194
# Job that runs ts-api-guardian against our API goldens in "tools/public_api_guard".
174195
# This job fails whenever an API has been updated but not explicitly approved through goldens.
@@ -554,6 +575,8 @@ workflows:
554575
jobs:
555576
- bazel_build:
556577
filters: *ignore_presubmit_branch_filter
578+
- view_engine_build:
579+
filters: *ignore_presubmit_branch_filter
557580
- view_engine_test:
558581
filters: *ignore_presubmit_branch_filter
559582
- api_golden_checks:

0 commit comments

Comments
 (0)