Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(scrolling): add dedicated module for CdkScrollable #19064

Merged
merged 1 commit into from
Apr 24, 2020
Merged

refactor(scrolling): add dedicated module for CdkScrollable #19064

merged 1 commit into from
Apr 24, 2020
+53 −19

Commits on Apr 23, 2020

  1. refactor(scrolling): add dedicated module for CdkScrollable 

    This is something that originally came up in angular#18082 and has been coming up as issues on GitHub. Some of our overlay-based components depend on `CdkScrollable` to tell them when to reposition, but the problem is that it's not very easy to consume, because:

1. It has an attribute selector so if it doesn't match, nothing will throw an error.
2. It has to be brought in through the `ScrollingModule` into the proper user module. The `ScrollingModule` is somewhat large, because it contains other things like virtual scrolling.

These changes address the issues by adding a small module dedicated only to `CdkScrollable`, and exporting the module through the relevant Material components.
    @crisbeto
    crisbeto committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    415a407 View commit details
    Browse the repository at this point in the history