refactor(scrolling): add dedicated module for CdkScrollable #19064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
scrollable-module
branch
from
405fc96
to
b904fe8
Compare
crisbeto
added
P2
|
@crisbeto passes presubmit, just needs rebase |
This is something that originally came up in angular#18082 and has been coming up as issues on GitHub. Some of our overlay-based components depend on `CdkScrollable` to tell them when to reposition, but the problem is that it's not very easy to consume, because: 1. It has an attribute selector so if it doesn't match, nothing will throw an error. 2. It has to be brought in through the `ScrollingModule` into the proper user module. The `ScrollingModule` is somewhat large, because it contains other things like virtual scrolling. These changes address the issues by adding a small module dedicated only to `CdkScrollable`, and exporting the module through the relevant Material components.
|
Rebased @jelbourn. |
crisbeto
force-pushed
the
scrollable-module
branch
from
b904fe8
to
415a407
Compare
jelbourn
pushed a commit
that referenced
this pull request
Apr 24, 2020
This is something that originally came up in #18082 and has been coming up as issues on GitHub. Some of our overlay-based components depend on `CdkScrollable` to tell them when to reposition, but the problem is that it's not very easy to consume, because: 1. It has an attribute selector so if it doesn't match, nothing will throw an error. 2. It has to be brought in through the `ScrollingModule` into the proper user module. The `ScrollingModule` is somewhat large, because it contains other things like virtual scrolling. These changes address the issues by adding a small module dedicated only to `CdkScrollable`, and exporting the module through the relevant Material components.
soro-google
pushed a commit
to soro-google/components
that referenced
this pull request
Apr 24, 2020
…19064) This is something that originally came up in angular#18082 and has been coming up as issues on GitHub. Some of our overlay-based components depend on `CdkScrollable` to tell them when to reposition, but the problem is that it's not very easy to consume, because: 1. It has an attribute selector so if it doesn't match, nothing will throw an error. 2. It has to be brought in through the `ScrollingModule` into the proper user module. The `ScrollingModule` is somewhat large, because it contains other things like virtual scrolling. These changes address the issues by adding a small module dedicated only to `CdkScrollable`, and exporting the module through the relevant Material components.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something that originally came up in #18082 and has been coming up as issues on GitHub. Some of our overlay-based components depend on
CdkScrollableto tell them when to reposition, but the problem is that it's not very easy to consume, because:ScrollingModuleinto the proper user module. TheScrollingModuleis somewhat large, because it contains other things like virtual scrolling.These changes address the issues by adding a small module dedicated only to
CdkScrollable, and exporting the module through the relevant Material components.Note: I'm setting this as a P2, because it should be relatively safe to land and we get related issue reports about it once in a while.