fix(material-experimental/popover-edit): closing instantly when opening with enter key - #18444
Merged
Merged
Conversation
…ng with enter key We use `keydown` to open the popover edit overlay and `keyup` to close it which can lead to situations where the user opens and closes the popup immediately. Seems to have been introduced by angular#18194.
crisbeto
added
P3
googlebot
added
the
cla: yes
kseamon
reviewed
Feb 11, 2020
kseamon
left a comment
kseamon
left a comment
Contributor
There was a problem hiding this comment.
Please experiment with both opening and confirming/closing the popups in various examples - I had similar issues with it immediately reopening after closing via enter in the past and changes like this could regress on that.
Otherwise, LGTM.
Member
Author
|
I played around with all the live examples in the dev app and it seemed fine, but maybe there's a particular one I should be looking at? |
andrewseguin
approved these changes
Jun 15, 2020
andrewseguin
added
lgtm
action: merge
devversion
pushed a commit
to devversion/material2
that referenced
this pull request
Jun 18, 2020
…ng with enter key (angular#18444) We use `keydown` to open the popover edit overlay and `keyup` to close it which can lead to situations where the user opens and closes the popup immediately. Seems to have been introduced by angular#18194.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use
keydownto open the popover edit overlay andkeyupto close it which can lead to situations where the user opens and closes the popup immediately. Seems to have been introduced by #18194.For reference:
cc @kseamon