feat(popover-edit): Adds support for select-like interactions. - #18194
Merged
Conversation
googlebot
added
the
cla: yes
…ect-like interactions. Includes minor behavior and style updates to PopoverEdit and an updated demo showing off the new interaction.
kseamon
force-pushed
the
popover-edit-select-menu
branch
from
January 16, 2020 18:55
4f8dd4b to
6a25079
Compare
jelbourn
added
pr: lgtm
action: merge
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Jan 30, 2020
…ect-like interactions. (angular#18194) Includes minor behavior and style updates to PopoverEdit and an updated demo showing off the new interaction.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Feb 9, 2020
…ng with enter key We use `keydown` to open the popover edit overlay and `keyup` to close it which can lead to situations where the user opens and closes the popup immediately. Seems to have been introduced by angular#18194.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes minor behavior and style updates to PopoverEdit that enable it to work nicely with MatSelectionList for select-style popover edits.
Includes an updated demo showing off the new interaction.