perf(popover-edit): collect common services into a single class for dependency injection #15797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Note that this is rebased over top of #15762 and #15793 so only the d0a8715 is up for review. Not sure if you all are going to like this one, but it does produce a measurable speed improvement that I think is worthwhile given that hundreds or maybe even thousands of edits could be a in a real-world table. |
…ependency injection I measured a savings of 0.023ms per CdkPopoverEdit instance at startup. There should also be additional savings in CdkRowHoverContent that I did not measure.
kseamon
force-pushed
the
popover-edit-di-performance-check
branch
from
d0a8715 to
c970705
Compare
jelbourn
added
pr: lgtm
action: merge
RudolfFrederiksen
pushed a commit
to RudolfFrederiksen/material2
that referenced
this pull request
Jun 21, 2019
…ependency injection (angular#15797) I measured a savings of 0.023ms per CdkPopoverEdit instance at startup. There should also be additional savings in CdkRowHoverContent that I did not measure.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I measured a savings of 0.023ms per CdkPopoverEdit instance at startup, roughly a 10% improvement in script time. There should
be additional savings in CdkRowHoverContent that I did not measure.