Skip to content

feat(popover-edit): Arrow keys move focus to neighboring cells #15762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2019

Conversation

kseamon
Copy link
Collaborator

@kseamon kseamon commented Apr 8, 2019

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 8, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good

@kseamon kseamon force-pushed the popover-edit-arrow-keys branch from ae48278 to 1f2328e Compare April 9, 2019 18:34
@kseamon kseamon marked this pull request as ready for review April 9, 2019 18:40
@kseamon kseamon requested a review from andrewseguin as a code owner April 9, 2019 18:40
@kseamon kseamon force-pushed the popover-edit-arrow-keys branch 2 times, most recently from 553f056 to 123bda5 Compare April 9, 2019 21:21
@kseamon kseamon force-pushed the popover-edit-arrow-keys branch from 123bda5 to d4988df Compare April 9, 2019 21:26
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Apr 9, 2019
@jelbourn jelbourn merged commit f6edba3 into angular:master Apr 11, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants